From 6f8035a265a73a38424ef04c5a76e17bf7ad17a5 Mon Sep 17 00:00:00 2001
From: Morgan Bentell <mbentell@spotify.com>
Date: Mon, 20 Mar 2023 13:13:37 +0100
Subject: [PATCH] make unmount effect more explicit

Signed-off-by: Morgan Bentell <mbentell@spotify.com>
---
 plugins/techdocs-react/src/hooks.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/plugins/techdocs-react/src/hooks.ts b/plugins/techdocs-react/src/hooks.ts
index 4007db58cd..d084a91cf5 100644
--- a/plugins/techdocs-react/src/hooks.ts
+++ b/plugins/techdocs-react/src/hooks.ts
@@ -82,7 +82,10 @@ export const useShadowRootSelection = (waitMillis: number = 0) => {
     [shadowRoot, setSelection, waitMillis],
   );
 
-  useEffect(() => handleSelectionChange.cancel, [handleSelectionChange.cancel]);
+  useEffect(() => {
+    // cancel debounce on unmount
+    return () => handleSelectionChange.cancel();
+  }, [handleSelectionChange]);
 
   useEffect(() => {
     window.document.addEventListener('selectionchange', handleSelectionChange);