From 1da51fec2b8949c7f4007f4939ce761c0fb46f9f Mon Sep 17 00:00:00 2001 From: Oliver Sand Date: Mon, 13 Sep 2021 13:53:14 +0200 Subject: [PATCH 1/3] Adjust dependencies to `@types/react` and `react-router` to follow the pattern used by all other Backstage packages Signed-off-by: Oliver Sand --- .changeset/techdocs-small-bugs-exist.md | 6 ++++++ plugins/home/package.json | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/techdocs-small-bugs-exist.md diff --git a/.changeset/techdocs-small-bugs-exist.md b/.changeset/techdocs-small-bugs-exist.md new file mode 100644 index 0000000000..5e7c01c1a4 --- /dev/null +++ b/.changeset/techdocs-small-bugs-exist.md @@ -0,0 +1,6 @@ +--- +'@backstage/plugin-home': patch +--- + +Adjust dependencies to `@types/react` and `react-router` to follow the pattern +used by all other Backstage packages. diff --git a/plugins/home/package.json b/plugins/home/package.json index 8ae92e8ace..8fe7826e2e 100644 --- a/plugins/home/package.json +++ b/plugins/home/package.json @@ -26,10 +26,10 @@ "@material-ui/core": "^4.12.2", "@material-ui/icons": "^4.9.1", "@material-ui/lab": "4.0.0-alpha.45", - "@types/react": "^16.9", + "@types/react": "*", "react": "^16.13.1", "react-dom": "^16.13.1", - "react-router": "^6.0.0-beta.0", + "react-router": "6.0.0-beta.0", "react-use": "^17.2.4" }, "devDependencies": { From 8b1db3ecfe9a0e9167fb48d1be9df9b18600e06c Mon Sep 17 00:00:00 2001 From: Oliver Sand Date: Mon, 13 Sep 2021 13:53:27 +0200 Subject: [PATCH 2/3] Fix mistake in readme Signed-off-by: Oliver Sand --- plugins/home/README.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/plugins/home/README.md b/plugins/home/README.md index a09c85775b..42cd88b879 100644 --- a/plugins/home/README.md +++ b/plugins/home/README.md @@ -43,9 +43,14 @@ import { HomepageCompositionRoot } from '@backstage/plugin-home'; import { HomePage } from './components/home/HomePage'; // ... -}> - -; + + + + } +/>; // ... ``` From be455f10250aa6dae7aba120531527ca18018217 Mon Sep 17 00:00:00 2001 From: Oliver Sand Date: Mon, 13 Sep 2021 14:38:30 +0200 Subject: [PATCH 3/3] Restore readme Signed-off-by: Oliver Sand --- plugins/home/README.md | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/plugins/home/README.md b/plugins/home/README.md index 42cd88b879..a09c85775b 100644 --- a/plugins/home/README.md +++ b/plugins/home/README.md @@ -43,14 +43,9 @@ import { HomepageCompositionRoot } from '@backstage/plugin-home'; import { HomePage } from './components/home/HomePage'; // ... - - - - } -/>; +}> + +; // ... ```