permission-node rename createIsAuthorized to createConditionAuthorizer

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
This commit is contained in:
Vincenzo Scamporlino
2023-03-09 12:32:19 +01:00
parent 5118294421
commit 6e5e1b49c0
3 changed files with 10 additions and 8 deletions
@@ -25,7 +25,7 @@ import { z } from 'zod';
import {
createPermissionIntegrationRouter,
CreatePermissionIntegrationRouterResourceOptions,
createIsAuthorized,
createConditionAuthorizer,
} from './createPermissionIntegrationRouter';
import { createPermissionRule } from './createPermissionRule';
@@ -633,13 +633,13 @@ describe('createPermissionIntegrationRouter', () => {
});
});
describe('createIsAuthorized', () => {
describe('createConditionAuthorizer', () => {
afterEach(() => {
jest.clearAllMocks();
});
it('should return true in case of allowed decision', () => {
const isAuthorized = createIsAuthorized([testRule1, testRule2]);
const isAuthorized = createConditionAuthorizer([testRule1, testRule2]);
expect(
isAuthorized(
{
@@ -653,7 +653,7 @@ describe('createIsAuthorized', () => {
expect(mockTestRule2Apply).not.toHaveBeenCalled();
});
it('should return false in case of denied decision', () => {
const isAuthorized = createIsAuthorized([testRule1, testRule2]);
const isAuthorized = createConditionAuthorizer([testRule1, testRule2]);
expect(
isAuthorized(
{
@@ -668,7 +668,7 @@ describe('createIsAuthorized', () => {
});
it('should apply conditions to a resource in case of conditional decision', () => {
const isAuthorized = createIsAuthorized([testRule1, testRule2]);
const isAuthorized = createConditionAuthorizer([testRule1, testRule2]);
expect(
isAuthorized(
{
@@ -168,7 +168,7 @@ const applyConditions = <TResourceType extends string, TResource>(
*
* @public
*/
export const createIsAuthorized = <TResource, TQuery>(
export const createConditionAuthorizer = <TResource, TQuery>(
rules: PermissionRule<TResource, TQuery, string>[],
) => {
const getRule = createGetRule(rules);
@@ -62,12 +62,14 @@ import {
import { TemplateAction } from '@backstage/plugin-scaffolder-node';
import { PermissionEvaluator } from '@backstage/plugin-permission-common';
import {
createIsAuthorized,
createConditionAuthorizer,
createPermissionIntegrationRouter,
} from '@backstage/plugin-permission-node';
import { scaffolderTemplateRules } from './rules';
const isAuthorized = createIsAuthorized(Object.values(scaffolderTemplateRules));
const isAuthorized = createConditionAuthorizer(
Object.values(scaffolderTemplateRules),
);
/**
* RouterOptions