From 6d8b4f90de9f83e4fa73784e4a0c98192b63cc7c Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Fri, 28 Feb 2020 09:18:07 +0100 Subject: [PATCH] packages/cli: lint fixes --- frontend/packages/cli/src/commands/serve/index.ts | 2 +- frontend/packages/cli/src/commands/watch-deps/index.ts | 2 +- frontend/packages/cli/src/commands/watch-deps/logger.ts | 8 +++----- frontend/packages/cli/src/index.ts | 1 + 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/frontend/packages/cli/src/commands/serve/index.ts b/frontend/packages/cli/src/commands/serve/index.ts index c67a375d72..4ea8c72c36 100644 --- a/frontend/packages/cli/src/commands/serve/index.ts +++ b/frontend/packages/cli/src/commands/serve/index.ts @@ -5,7 +5,7 @@ export default async () => { try { await startDevServer(); } catch (error) { - console.error(chalk.red(error.message)); + process.stderr.write(`${chalk.red(error.message)}\n`); process.exit(1); } }; diff --git a/frontend/packages/cli/src/commands/watch-deps/index.ts b/frontend/packages/cli/src/commands/watch-deps/index.ts index 2a283cf094..cbfc1089b6 100644 --- a/frontend/packages/cli/src/commands/watch-deps/index.ts +++ b/frontend/packages/cli/src/commands/watch-deps/index.ts @@ -43,7 +43,7 @@ export default async (_command: any, args: string[]) => { // We lazily watch all our deps, as in we don't start the actual watch compiler until a change is detected await startWatchers(allDeps, WATCH_LOCATIONS, pkg => { startCompiler(pkg, logFactory(pkg.name)).promise.catch(error => { - console.error(error); + process.stderr.write(`${error}\n`); }); }); diff --git a/frontend/packages/cli/src/commands/watch-deps/logger.ts b/frontend/packages/cli/src/commands/watch-deps/logger.ts index 59020ec1ca..f443de6cd4 100644 --- a/frontend/packages/cli/src/commands/watch-deps/logger.ts +++ b/frontend/packages/cli/src/commands/watch-deps/logger.ts @@ -8,11 +8,9 @@ export type ColorFunc = (msg: string) => string; // Logger utility that prefixes logs and removes terminal clear commands export function createLogger(prefix: string = ''): Logger { const write = (stream: NodeJS.WriteStream, msg: string) => { - if (msg.startsWith('\x1b\x63')) { - msg = msg.slice(2); - } - const str = msg.trimRight().replace(/^/gm, prefix) + '\n'; - stream.write(str, 'utf8'); + const noClearMsg = msg.startsWith('\x1b\x63') ? msg.slice(2) : msg; + const prefixedMsg = noClearMsg.trimRight().replace(/^/gm, prefix); + stream.write(`${prefixedMsg}\n`, 'utf8'); }; return { diff --git a/frontend/packages/cli/src/index.ts b/frontend/packages/cli/src/index.ts index 61edb80898..ade0f9276d 100644 --- a/frontend/packages/cli/src/index.ts +++ b/frontend/packages/cli/src/index.ts @@ -24,6 +24,7 @@ const main = (argv: string[]) => { .action(watch); program.on('command:*', () => { + // eslint-disable-next-line no-console console.error( 'Invalid command: %s\nSee --help for a list of available commands.', program.args.join(' '),