chore: rename SignalService to SignalsService

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
This commit is contained in:
Heikki Hellgren
2024-03-12 08:54:03 +02:00
parent 0b120df27b
commit 6d84ee63ce
18 changed files with 137 additions and 56 deletions
@@ -13,15 +13,15 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { DefaultSignalService } from './DefaultSignalService';
import { DefaultSignalsService } from './DefaultSignalsService';
describe('DefaultSignalService', () => {
describe('DefaultSignalsService', () => {
const mockEvents = {
publish: jest.fn(),
subscribe: jest.fn(),
};
const service = DefaultSignalService.create({ events: mockEvents });
const service = DefaultSignalsService.create({ events: mockEvents });
it('should publish signal', () => {
const signal = {
@@ -14,19 +14,19 @@
* limitations under the License.
*/
import { EventsService } from '@backstage/plugin-events-node';
import { SignalPayload, SignalServiceOptions } from './types';
import { SignalService } from './SignalService';
import { SignalPayload, SignalsServiceOptions } from './types';
import { SignalsService } from './SignalsService';
import { JsonObject } from '@backstage/types';
/** @public */
export class DefaultSignalService implements SignalService {
export class DefaultSignalsService implements SignalsService {
private events: EventsService;
static create(options: SignalServiceOptions) {
return new DefaultSignalService(options);
static create(options: SignalsServiceOptions) {
return new DefaultSignalsService(options);
}
private constructor(options: SignalServiceOptions) {
private constructor(options: SignalsServiceOptions) {
({ events: this.events } = options);
}
@@ -43,3 +43,9 @@ export class DefaultSignalService implements SignalService {
});
}
}
/**
* @public
* @deprecated Use `DefaultSignalsService` instead
*/
export const DefaultSignalService = DefaultSignalsService;
@@ -17,7 +17,7 @@ import { SignalPayload } from './types';
import { JsonObject } from '@backstage/types';
/** @public */
export interface SignalService {
export interface SignalsService {
/**
* Publishes a signal to user refs to specific topic
* @param signal - Signal to publish
@@ -26,3 +26,9 @@ export interface SignalService {
signal: SignalPayload<TMessage>,
): Promise<void>;
}
/**
* @public
* @deprecated Use `SignalsService` instead
*/
export interface SignalService extends SignalsService {}
+2 -2
View File
@@ -15,6 +15,6 @@
*/
export * from './lib';
export * from './DefaultSignalService';
export * from './SignalService';
export * from './DefaultSignalsService';
export * from './SignalsService';
export * from './types';
+10 -4
View File
@@ -17,12 +17,12 @@ import {
createServiceFactory,
createServiceRef,
} from '@backstage/backend-plugin-api';
import { DefaultSignalService } from './DefaultSignalService';
import { SignalService } from './SignalService';
import { DefaultSignalsService } from './DefaultSignalsService';
import { SignalsService } from './SignalsService';
import { eventsServiceRef } from '@backstage/plugin-events-node';
/** @public */
export const signalService = createServiceRef<SignalService>({
export const signalsServiceRef = createServiceRef<SignalsService>({
id: 'signals.service',
scope: 'plugin',
defaultFactory: async service =>
@@ -32,7 +32,13 @@ export const signalService = createServiceRef<SignalService>({
events: eventsServiceRef,
},
factory({ events }) {
return DefaultSignalService.create({ events });
return DefaultSignalsService.create({ events });
},
}),
});
/**
* @public
* @deprecated Use `signalsServiceRef` instead
*/
export const signalService = signalsServiceRef;
+1 -1
View File
@@ -19,7 +19,7 @@ import { JsonObject } from '@backstage/types';
/**
* @public
*/
export type SignalServiceOptions = {
export type SignalsServiceOptions = {
events: EventsService;
};