From 6bf7561d3c264d8c3bc03ca8443d72e6ff82ce81 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 20 Oct 2023 11:42:19 +0200
Subject: [PATCH] cli: fix package detection breaking if package.json is not
 available

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .changeset/rich-pugs-chew.md                  |  5 +++
 .../cli/src/lib/bundler/packageDetection.ts   | 38 ++++++++++---------
 2 files changed, 26 insertions(+), 17 deletions(-)
 create mode 100644 .changeset/rich-pugs-chew.md

diff --git a/.changeset/rich-pugs-chew.md b/.changeset/rich-pugs-chew.md
new file mode 100644
index 0000000000..6c5aa0af62
--- /dev/null
+++ b/.changeset/rich-pugs-chew.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+The experimental package detection will now ignore packages that don't make `package.json` available.
diff --git a/packages/cli/src/lib/bundler/packageDetection.ts b/packages/cli/src/lib/bundler/packageDetection.ts
index 2095fe23e7..3aa0955c06 100644
--- a/packages/cli/src/lib/bundler/packageDetection.ts
+++ b/packages/cli/src/lib/bundler/packageDetection.ts
@@ -77,24 +77,28 @@ async function detectPackages(
       return [];
     }
 
-    const depPackageJson: BackstagePackageJson = require(require.resolve(
-      `${depName}/package.json`,
-      { paths: [targetPath] },
-    ));
-    if (
-      ['frontend-plugin', 'frontend-plugin-module'].includes(
-        depPackageJson.backstage?.role ?? '',
-      )
-    ) {
-      // Include alpha entry point if available. If there's no default export it will be ignored
-      const exp = depPackageJson.exports;
-      if (exp && typeof exp === 'object' && './alpha' in exp) {
-        return [
-          { name: depName, import: depName },
-          { name: depName, export: './alpha', import: `${depName}/alpha` },
-        ];
+    try {
+      const depPackageJson: BackstagePackageJson = require(require.resolve(
+        `${depName}/package.json`,
+        { paths: [targetPath] },
+      ));
+      if (
+        ['frontend-plugin', 'frontend-plugin-module'].includes(
+          depPackageJson.backstage?.role ?? '',
+        )
+      ) {
+        // Include alpha entry point if available. If there's no default export it will be ignored
+        const exp = depPackageJson.exports;
+        if (exp && typeof exp === 'object' && './alpha' in exp) {
+          return [
+            { name: depName, import: depName },
+            { name: depName, export: './alpha', import: `${depName}/alpha` },
+          ];
+        }
+        return [{ name: depName, import: depName }];
       }
-      return [{ name: depName, import: depName }];
+    } catch {
+      /* ignore packages that don't make package.json available */
     }
     return [];
   });