diff --git a/.changeset/early-hairs-switch.md b/.changeset/early-hairs-switch.md
new file mode 100644
index 0000000000..16f4298db5
--- /dev/null
+++ b/.changeset/early-hairs-switch.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+changed tests created by create-plugin to follow eslint-rules best practices particularly testing-library/prefer-screen-queries and testing-library/render-result-naming-convention
diff --git a/packages/cli/templates/default-plugin/src/components/ExampleComponent/ExampleComponent.test.tsx.hbs b/packages/cli/templates/default-plugin/src/components/ExampleComponent/ExampleComponent.test.tsx.hbs
index ccbebcac40..ae626c0d57 100644
--- a/packages/cli/templates/default-plugin/src/components/ExampleComponent/ExampleComponent.test.tsx.hbs
+++ b/packages/cli/templates/default-plugin/src/components/ExampleComponent/ExampleComponent.test.tsx.hbs
@@ -4,6 +4,7 @@ import { ThemeProvider } from '@material-ui/core';
import { lightTheme } from '@backstage/theme';
import { rest } from 'msw';
import { setupServer } from 'msw/node';
+import { screen } from '@testing-library/react';
import {
setupRequestMockHandlers,
renderInTestApp,
@@ -22,11 +23,11 @@ describe('ExampleComponent', () => {
});
it('should render', async () => {
- const rendered = await renderInTestApp(
+ await renderInTestApp(
,
);
- expect(rendered.getByText('Welcome to {{ id }}!')).toBeInTheDocument();
+ expect(screen.getByText('Welcome to {{ id }}!')).toBeInTheDocument();
});
});
diff --git a/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs b/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs
index 95533c899d..a553ecd0b0 100644
--- a/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs
+++ b/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs
@@ -1,5 +1,5 @@
import React from 'react';
-import { render } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
import { ExampleFetchComponent } from './ExampleFetchComponent';
import { rest } from 'msw';
import { setupServer } from 'msw/node';
@@ -19,7 +19,7 @@ describe('ExampleFetchComponent', () => {
);
});
it('should render', async () => {
- const rendered = render();
- expect(await rendered.findByTestId('progress')).toBeInTheDocument();
+ await render();
+ expect(await screen.findByTestId('progress')).toBeInTheDocument();
});
});