From 6b28fa1312fc9e0d6d1bb67cc2fe062c4ea790c1 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Wed, 20 Oct 2021 14:58:41 +0200
Subject: [PATCH] chore: adding deprecation warnings for routeRef deprecated
 options

Signed-off-by: blam <ben@blam.sh>
---
 .../core-plugin-api/src/routing/RouteRef.ts   | 26 ++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/packages/core-plugin-api/src/routing/RouteRef.ts b/packages/core-plugin-api/src/routing/RouteRef.ts
index a926b775e6..377053daf8 100644
--- a/packages/core-plugin-api/src/routing/RouteRef.ts
+++ b/packages/core-plugin-api/src/routing/RouteRef.ts
@@ -23,7 +23,6 @@ import {
 } from './types';
 import { OldIconComponent } from '../icons/types';
 
-// TODO(Rugvip): Remove this in the next breaking release, it's exported but unused
 /**
  * @deprecated
  * @internal
@@ -53,13 +52,34 @@ export class RouteRefImpl<Params extends AnyParams>
       icon?: OldIconComponent;
       title?: string;
     },
-  ) {}
+  ) {
+    if (config.path) {
+      // eslint-disable-next-line no-console
+      console.warn(
+        `[core-plugin-api] - routeRefs no longer decide their own path, please remove the path for ${this.toString()}. This will be removed in upcoming versions.`,
+      );
+    }
+
+    if (config.icon) {
+      // eslint-disable-next-line no-console
+      console.warn(
+        `[core-plugin-api] - routeRefs no longer decide their own icon, please remove the icon for ${this.toString()}. This will be removed in upcoming versions.`,
+      );
+    }
+
+    if (config.title) {
+      // eslint-disable-next-line no-console
+      console.warn(
+        `[core-plugin-api] - routeRefs no longer decide their own title, please remove the title for ${this.toString()}. This will be removed in upcoming versions.`,
+      );
+    }
+  }
 
   get icon() {
     return this.config.icon;
   }
 
-  // TODO(Rugvip): Remove this, routes are looked up via the registry instead
+  /** @deprecated */
   get path() {
     return this.config.path ?? '';
   }