From 69405c52f8d1d72726994705e41798616b426110 Mon Sep 17 00:00:00 2001 From: angom1 Date: Thu, 31 Aug 2023 12:29:12 +0100 Subject: [PATCH] Simplify for loops Signed-off-by: angom1 --- .../catalog-backend-module-gitlab/src/lib/client.ts | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/plugins/catalog-backend-module-gitlab/src/lib/client.ts b/plugins/catalog-backend-module-gitlab/src/lib/client.ts index 4a5d70b0bf..65eb3f326a 100644 --- a/plugins/catalog-backend-module-gitlab/src/lib/client.ts +++ b/plugins/catalog-backend-module-gitlab/src/lib/client.ts @@ -150,11 +150,7 @@ export class GitLabClient { continue; } - const groupsData = response.data.group.descendantGroups.nodes; - - for (let i = 0; i < groupsData.length; i++) { - const groupItem = groupsData[i]; - + for (const groupItem of response.data.group.descendantGroups.nodes) { const formattedGroupResponse = { id: Number(groupItem.id.replace(/^gid:\/\/gitlab\/Group\//, '')), name: groupItem.name, @@ -236,11 +232,7 @@ export class GitLabClient { continue; } - const usersData = response.data.group.groupMembers.nodes; - - for (let i = 0; i < usersData.length; i++) { - const userItem = usersData[i]; - + for (const userItem of response.data.group.groupMembers.nodes) { const formattedUserResponse = { id: Number(userItem.user.id.replace(/^gid:\/\/gitlab\/User\//, '')), username: userItem.user.username,