From 67aa7e8176d8ea8b6a52554995525481b80046c3 Mon Sep 17 00:00:00 2001 From: Adam Shurson Date: Mon, 21 Sep 2020 13:46:13 -0500 Subject: [PATCH] tests(register-component): update tests to use test-id for submit button --- .../RegisterComponentForm/RegisterComponentForm.test.tsx | 8 ++++++-- .../RegisterComponentForm/RegisterComponentForm.tsx | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx index bb7faabc9d..df179ca219 100644 --- a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx +++ b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx @@ -41,7 +41,9 @@ describe('RegisterComponentForm', () => { ), ).toBeInTheDocument(); - const submit = (await rendered.getByRole('button')) as HTMLButtonElement; + const submit = (await rendered.getByTestId( + 'registerComponentFormSubmit', + )) as HTMLButtonElement; expect(submit.disabled).toBeTruthy(); }); @@ -54,7 +56,9 @@ describe('RegisterComponentForm', () => { target: { value: 'https://example.com/blob/master/component.yaml' }, }); }); - const submit = (await rendered.getByRole('button')) as HTMLButtonElement; + const submit = (await rendered.getByTestId( + 'registerComponentFormSubmit', + )) as HTMLButtonElement; expect(submit.disabled).toBeFalsy(); }); diff --git a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx index f98ff22a15..294f4db801 100644 --- a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx +++ b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx @@ -113,6 +113,7 @@ const RegisterComponentForm: FC = ({ onSubmit, submitting }) => {