From 66dfb03b86e9b44d0b479629104982dfb2f0fcab Mon Sep 17 00:00:00 2001 From: Wiktor Czajkowski Date: Thu, 14 Nov 2024 15:38:16 +0100 Subject: [PATCH] add data-testid to Progress placeholder Signed-off-by: Wiktor Czajkowski --- .../src/components/Progress/Progress.test.tsx | 9 +++++++-- .../core-components/src/components/Progress/Progress.tsx | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/core-components/src/components/Progress/Progress.test.tsx b/packages/core-components/src/components/Progress/Progress.test.tsx index d4057c1675..f060ff0ea0 100644 --- a/packages/core-components/src/components/Progress/Progress.test.tsx +++ b/packages/core-components/src/components/Progress/Progress.test.tsx @@ -23,12 +23,17 @@ import { Progress } from './Progress'; describe('', () => { it('renders without exploding', async () => { jest.useFakeTimers(); - const { getByTestId, queryByTestId } = await renderInTestApp(); + const { getByTestId, queryByTestId, debug } = await renderInTestApp( + , + ); + debug(); + expect(queryByTestId('progress-placeholder')).toBeInTheDocument(); expect(queryByTestId('progress')).not.toBeInTheDocument(); act(() => { jest.advanceTimersByTime(250); }); - expect(getByTestId('progress')).toBeInTheDocument(); + expect(queryByTestId('progress-placeholder')).not.toBeInTheDocument(); + expect(queryByTestId('progress')).toBeInTheDocument(); jest.useRealTimers(); }); }); diff --git a/packages/core-components/src/components/Progress/Progress.tsx b/packages/core-components/src/components/Progress/Progress.tsx index 6d1281edd5..171d8210bd 100644 --- a/packages/core-components/src/components/Progress/Progress.tsx +++ b/packages/core-components/src/components/Progress/Progress.tsx @@ -36,6 +36,6 @@ export function Progress(props: PropsWithChildren) { return isVisible ? ( ) : ( - + ); }