From 66aa05c23c7700f19c18a6327e521db6c26405fa Mon Sep 17 00:00:00 2001 From: Jen Evans Date: Wed, 23 Feb 2022 10:49:29 -0800 Subject: [PATCH] Fix pagePause true bug Signed-off-by: Jen Evans --- .changeset/spicy-lies-grin.md | 5 +++++ plugins/catalog-backend-module-ldap/src/ldap/client.ts | 6 ++++++ 2 files changed, 11 insertions(+) create mode 100644 .changeset/spicy-lies-grin.md diff --git a/.changeset/spicy-lies-grin.md b/.changeset/spicy-lies-grin.md new file mode 100644 index 0000000000..f984c1a4ef --- /dev/null +++ b/.changeset/spicy-lies-grin.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-backend-module-ldap': patch +--- + +Fixed bug in Catalog LDAP module to ack page events to continue receiving entries if pagePause=true diff --git a/plugins/catalog-backend-module-ldap/src/ldap/client.ts b/plugins/catalog-backend-module-ldap/src/ldap/client.ts index 91fbd87c39..708d53b7f7 100644 --- a/plugins/catalog-backend-module-ldap/src/ldap/client.ts +++ b/plugins/catalog-backend-module-ldap/src/ldap/client.ts @@ -106,6 +106,12 @@ export class LdapClient { reject(new Error(errorString(e))); }); + res.on('page', (result, cb) => { + if (cb) { + cb(); + } + }); + res.on('end', r => { if (!r) { reject(new Error('Null response'));