From 6676b0e137b03e4866bf43c3525fcc0763f7316f Mon Sep 17 00:00:00 2001
From: AmbrishRamachandiran <ambrish.r@infosys.com>
Date: Wed, 4 Mar 2026 19:08:25 +0530
Subject: [PATCH] Fix review comments

Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
---
 packages/ui/src/components/RangeSlider/RangeSlider.tsx | 6 ++++--
 packages/ui/src/components/RangeSlider/types.ts        | 5 -----
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/packages/ui/src/components/RangeSlider/RangeSlider.tsx b/packages/ui/src/components/RangeSlider/RangeSlider.tsx
index d9baa38814..7796634a7a 100644
--- a/packages/ui/src/components/RangeSlider/RangeSlider.tsx
+++ b/packages/ui/src/components/RangeSlider/RangeSlider.tsx
@@ -38,6 +38,9 @@ export const RangeSlider = forwardRef<HTMLDivElement, RangeSliderProps>(
       'aria-labelledby': ariaLabelledBy,
     } = props;
 
+    // Extract isRequired early since it's inherited from AriaSliderProps
+    const isRequired = 'isRequired' in props ? props.isRequired : undefined;
+
     useEffect(() => {
       if (!label && !ariaLabel && !ariaLabelledBy) {
         console.warn(
@@ -73,7 +76,7 @@ export const RangeSlider = forwardRef<HTMLDivElement, RangeSliderProps>(
 
     useEffect(() => {
       if (
-        rawDefaultValue &&
+        rawDefaultValue !== undefined &&
         (!Array.isArray(rawDefaultValue) ||
           rawDefaultValue.length !== 2 ||
           typeof rawDefaultValue[0] !== 'number' ||
@@ -122,7 +125,6 @@ export const RangeSlider = forwardRef<HTMLDivElement, RangeSliderProps>(
       className,
       description,
       secondaryLabel,
-      isRequired,
       showValueLabel = false,
       formatValue = (val: number) => val.toString(),
       ...rest
diff --git a/packages/ui/src/components/RangeSlider/types.ts b/packages/ui/src/components/RangeSlider/types.ts
index ad93f7c9d4..1f09cfc713 100644
--- a/packages/ui/src/components/RangeSlider/types.ts
+++ b/packages/ui/src/components/RangeSlider/types.ts
@@ -31,9 +31,4 @@ export interface RangeSliderProps
    * Format the value for display
    */
   formatValue?: (value: number) => string;
-
-  /**
-   * Whether the slider is required (displays "Required" in the label)
-   */
-  isRequired?: boolean;
 }