diff --git a/packages/app/src/components/search/SearchPage.tsx b/packages/app/src/components/search/SearchPage.tsx index 4579491961..7b94e876e6 100644 --- a/packages/app/src/components/search/SearchPage.tsx +++ b/packages/app/src/components/search/SearchPage.tsx @@ -21,7 +21,7 @@ import { Content, Header, Lifecycle, Page } from '@backstage/core'; import { CatalogResultListItem } from '@backstage/plugin-catalog'; import { SearchBar, - SearchFilterNext as SearchFilter, + SearchFilter, SearchResult, DefaultResultListItem, } from '@backstage/plugin-search'; diff --git a/plugins/search/src/components/SearchFilterNext/SearchFilterNext.test.tsx b/plugins/search/src/components/SearchFilter/SearchFilter.test.tsx similarity index 92% rename from plugins/search/src/components/SearchFilterNext/SearchFilterNext.test.tsx rename to plugins/search/src/components/SearchFilter/SearchFilter.test.tsx index 1a35bf54d4..4e721d1eb8 100644 --- a/plugins/search/src/components/SearchFilterNext/SearchFilterNext.test.tsx +++ b/plugins/search/src/components/SearchFilter/SearchFilter.test.tsx @@ -19,7 +19,7 @@ import { screen, render, waitFor } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { useApi } from '@backstage/core'; -import { SearchFilterNext } from './SearchFilterNext'; +import { SearchFilter } from './SearchFilter'; import { SearchContextProvider } from '../SearchContext'; jest.mock('@backstage/core', () => ({ @@ -27,7 +27,7 @@ jest.mock('@backstage/core', () => ({ useApi: jest.fn().mockReturnValue({}), })); -describe('SearchFilterNext', () => { +describe('SearchFilter', () => { const initialState = { term: '', filters: {}, @@ -49,7 +49,7 @@ describe('SearchFilterNext', () => { it('Check that element was rendered and received props', async () => { const CustomFilter = (props: { name: string }) =>
{props.name}
; - render(); + render(); expect(screen.getByRole('heading', { name })).toBeInTheDocument(); }); @@ -58,7 +58,7 @@ describe('SearchFilterNext', () => { it('Renders field name and values when provided as props', async () => { render( - + , ); @@ -84,7 +84,7 @@ describe('SearchFilterNext', () => { }, }} > - + , ); @@ -101,7 +101,7 @@ describe('SearchFilterNext', () => { it('Renders correctly based on defaultValue', async () => { render( - { it('Checking / unchecking a value sets filter state', async () => { render( - + , ); @@ -152,7 +152,7 @@ describe('SearchFilterNext', () => { it('Checking / unchecking a value maintains unrelated filter state', async () => { render( - + , ); @@ -186,7 +186,7 @@ describe('SearchFilterNext', () => { it('Renders field name and values when provided as props', async () => { render( - + , ); @@ -218,7 +218,7 @@ describe('SearchFilterNext', () => { }, }} > - + , ); @@ -247,7 +247,7 @@ describe('SearchFilterNext', () => { it('Renders correctly based on defaultValue', async () => { render( - { it('Selecting a value sets filter state', async () => { render( - + , ); @@ -331,7 +331,7 @@ describe('SearchFilterNext', () => { filters, }} > - + , ); diff --git a/plugins/search/src/components/SearchFilterNext/SearchFilterNext.tsx b/plugins/search/src/components/SearchFilter/SearchFilter.tsx similarity index 85% rename from plugins/search/src/components/SearchFilterNext/SearchFilterNext.tsx rename to plugins/search/src/components/SearchFilter/SearchFilter.tsx index 7beef58bc9..579d4af8df 100644 --- a/plugins/search/src/components/SearchFilterNext/SearchFilterNext.tsx +++ b/plugins/search/src/components/SearchFilter/SearchFilter.tsx @@ -164,16 +164,24 @@ const SelectFilter = ({ ); }; -const SearchFilterNext = ({ component: Element, ...props }: Props) => ( +const SearchFilter = ({ component: Element, ...props }: Props) => ( ); -SearchFilterNext.Checkbox = (props: Omit & Component) => ( - +SearchFilter.Checkbox = (props: Omit & Component) => ( + ); -SearchFilterNext.Select = (props: Omit & Component) => ( - +SearchFilter.Select = (props: Omit & Component) => ( + ); -export { SearchFilterNext }; +/** + * @deprecated This component was used for rapid prototyping of the Backstage + * Search platform. Now that the API has stabilized, you should use the + * component instead. This component will be removed in an + * upcoming release. + */ +const SearchFilterNext = SearchFilter; + +export { SearchFilter, SearchFilterNext }; diff --git a/plugins/search/src/components/SearchFilterNext/index.ts b/plugins/search/src/components/SearchFilter/index.ts similarity index 90% rename from plugins/search/src/components/SearchFilterNext/index.ts rename to plugins/search/src/components/SearchFilter/index.ts index 322abe64d7..c12591493d 100644 --- a/plugins/search/src/components/SearchFilterNext/index.ts +++ b/plugins/search/src/components/SearchFilter/index.ts @@ -14,4 +14,4 @@ * limitations under the License. */ -export { SearchFilterNext } from './SearchFilterNext'; +export { SearchFilter, SearchFilterNext } from './SearchFilter'; diff --git a/plugins/search/src/components/index.tsx b/plugins/search/src/components/index.tsx index 6bfb430f29..72bf9713ec 100644 --- a/plugins/search/src/components/index.tsx +++ b/plugins/search/src/components/index.tsx @@ -15,7 +15,7 @@ */ export * from './Filters'; -export * from './SearchFilterNext'; +export * from './SearchFilter'; export * from './SearchBar'; export * from './SearchPage'; export * from './SearchResult'; diff --git a/plugins/search/src/index.ts b/plugins/search/src/index.ts index 26f1c8f544..9cebd1bdd7 100644 --- a/plugins/search/src/index.ts +++ b/plugins/search/src/index.ts @@ -31,6 +31,7 @@ export { SearchContextProvider, useSearch, SearchPage as Router, + SearchFilter, SearchFilterNext, SidebarSearch, } from './components';