From 6647a686a740c63d61d9c2151231d6d6808da212 Mon Sep 17 00:00:00 2001 From: Aramis Sennyey Date: Tue, 29 Nov 2022 13:08:41 -0500 Subject: [PATCH] Don't allow relative urls at CLI time. Signed-off-by: Aramis Sennyey --- packages/cli/src/lib/bundler/config.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/cli/src/lib/bundler/config.ts b/packages/cli/src/lib/bundler/config.ts index ace60883a4..1974153f02 100644 --- a/packages/cli/src/lib/bundler/config.ts +++ b/packages/cli/src/lib/bundler/config.ts @@ -36,12 +36,10 @@ import { runPlain } from '../run'; import ESLintPlugin from 'eslint-webpack-plugin'; import pickBy from 'lodash/pickBy'; -const NO_OP_URL = 'http://test-site-asdf.org'; - export function resolveBaseUrl(config: Config): URL { const baseUrl = config.getString('app.baseUrl'); try { - return new URL(baseUrl, NO_OP_URL); + return new URL(baseUrl); } catch (error) { throw new Error(`Invalid app.baseUrl, ${error}`); } @@ -90,7 +88,7 @@ export async function createConfig( const externalPkgs = packages.filter(p => !isChildPath(paths.root, p.dir)); const baseUrl = frontendConfig.getString('app.baseUrl'); - const validBaseUrl = new URL(baseUrl, NO_OP_URL); + const validBaseUrl = new URL(baseUrl); const publicPath = validBaseUrl.pathname.replace(/\/$/, ''); if (checksEnabled) { plugins.push(