From 65b6a918944c7120b7ae69c218002b0e6699f6c5 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Wed, 18 Oct 2023 13:02:12 +0200
Subject: [PATCH] frontend-app-api: rename buildAppGraph -> resolveAppGraph

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/wiring/graph/instantiateAppNodeTree.test.ts  | 10 +++++-----
 ...buildAppGraph.test.ts => resolveAppGraph.test.ts} | 12 ++++++------
 .../graph/{buildAppGraph.ts => resolveAppGraph.ts}   |  2 +-
 3 files changed, 12 insertions(+), 12 deletions(-)
 rename packages/frontend-app-api/src/wiring/graph/{buildAppGraph.test.ts => resolveAppGraph.test.ts} (93%)
 rename packages/frontend-app-api/src/wiring/graph/{buildAppGraph.ts => resolveAppGraph.ts} (99%)

diff --git a/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts b/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts
index 43aad4f9ae..7bffc69c7c 100644
--- a/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts
+++ b/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts
@@ -26,7 +26,7 @@ import {
   instantiateAppNodeTree,
 } from './instantiateAppNodeTree';
 import { AppNodeInstance, AppNodeSpec } from './types';
-import { buildAppGraph } from './buildAppGraph';
+import { resolveAppGraph } from './resolveAppGraph';
 
 const testDataRef = createExtensionDataRef<string>('test');
 const otherDataRef = createExtensionDataRef<number>('other');
@@ -79,7 +79,7 @@ function makeInstanceWithId<TConfig>(
 
 describe('instantiateAppNodeTree', () => {
   it('should instantiate a single node', () => {
-    const graph = buildAppGraph(
+    const graph = resolveAppGraph(
       [{ ...makeSpec(simpleExtension), id: 'root-node' }],
       'root-node',
     );
@@ -94,7 +94,7 @@ describe('instantiateAppNodeTree', () => {
   });
 
   it('should not instantiate disabled nodes', () => {
-    const graph = buildAppGraph(
+    const graph = resolveAppGraph(
       [{ ...makeSpec(simpleExtension), id: 'root-node', disabled: true }],
       'root-node',
     );
@@ -104,7 +104,7 @@ describe('instantiateAppNodeTree', () => {
   });
 
   it('should instantiate a node with attachments', () => {
-    const graph = buildAppGraph(
+    const graph = resolveAppGraph(
       [
         {
           ...makeSpec(
@@ -151,7 +151,7 @@ describe('instantiateAppNodeTree', () => {
   });
 
   it('should not instantiate disabled attachments', () => {
-    const graph = buildAppGraph(
+    const graph = resolveAppGraph(
       [
         {
           ...makeSpec(
diff --git a/packages/frontend-app-api/src/wiring/graph/buildAppGraph.test.ts b/packages/frontend-app-api/src/wiring/graph/resolveAppGraph.test.ts
similarity index 93%
rename from packages/frontend-app-api/src/wiring/graph/buildAppGraph.test.ts
rename to packages/frontend-app-api/src/wiring/graph/resolveAppGraph.test.ts
index 8cf8279e96..2d1acbbc04 100644
--- a/packages/frontend-app-api/src/wiring/graph/buildAppGraph.test.ts
+++ b/packages/frontend-app-api/src/wiring/graph/resolveAppGraph.test.ts
@@ -15,7 +15,7 @@
  */
 
 import { createExtension } from '@backstage/frontend-plugin-api';
-import { buildAppGraph } from './buildAppGraph';
+import { resolveAppGraph } from './resolveAppGraph';
 
 const extBaseConfig = {
   id: 'test',
@@ -34,13 +34,13 @@ const baseSpec = {
 
 describe('buildAppGraph', () => {
   it('should fail to create an empty graph', () => {
-    expect(() => buildAppGraph([])).toThrow(
+    expect(() => resolveAppGraph([])).toThrow(
       "No root node with id 'core' found in app graph",
     );
   });
 
   it('should create a graph with only one node', () => {
-    const graph = buildAppGraph([{ ...baseSpec, id: 'core' }]);
+    const graph = resolveAppGraph([{ ...baseSpec, id: 'core' }]);
     expect(graph.root).toEqual({
       spec: { ...baseSpec, id: 'core' },
       edges: { attachments: new Map() },
@@ -50,7 +50,7 @@ describe('buildAppGraph', () => {
   });
 
   it('should create a graph', () => {
-    const graph = buildAppGraph(
+    const graph = resolveAppGraph(
       [
         { ...baseSpec, id: 'a' },
         { ...baseSpec, id: 'b' },
@@ -116,7 +116,7 @@ describe('buildAppGraph', () => {
   });
 
   it('should create a graph out of order', () => {
-    const graph = buildAppGraph(
+    const graph = resolveAppGraph(
       [
         { ...baseSpec, attachTo: { id: 'b', input: 'x' }, id: 'bx2' },
         { ...baseSpec, id: 'a' },
@@ -163,7 +163,7 @@ describe('buildAppGraph', () => {
 
   it('throws an error when duplicated extensions are detected', () => {
     expect(() =>
-      buildAppGraph([
+      resolveAppGraph([
         { ...baseSpec, id: 'a' },
         { ...baseSpec, id: 'a' },
       ]),
diff --git a/packages/frontend-app-api/src/wiring/graph/buildAppGraph.ts b/packages/frontend-app-api/src/wiring/graph/resolveAppGraph.ts
similarity index 99%
rename from packages/frontend-app-api/src/wiring/graph/buildAppGraph.ts
rename to packages/frontend-app-api/src/wiring/graph/resolveAppGraph.ts
index 06347b1ece..18f481fa30 100644
--- a/packages/frontend-app-api/src/wiring/graph/buildAppGraph.ts
+++ b/packages/frontend-app-api/src/wiring/graph/resolveAppGraph.ts
@@ -87,7 +87,7 @@ class SerializableAppNode implements AppNode {
  * tree with all attachments in the same order as they appear in the input specs array.
  * @internal
  */
-export function buildAppGraph(
+export function resolveAppGraph(
   specs: AppNodeSpec[],
   rootNodeId = 'core',
 ): AppGraph {