Modify fromConfig to actually use the config. Update api-reports.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
This commit is contained in:
Jussi Hallila
2021-09-13 09:54:12 +02:00
parent feea75ad49
commit 65a2d67735
4 changed files with 15 additions and 9 deletions
+1 -1
View File
@@ -47,7 +47,7 @@ export class DefaultTechDocsCollator implements DocumentCollator {
execute(): Promise<TechDocsDocument[]>;
// (undocumented)
static fromConfig(
_config: Config,
config: Config,
options: TechDocsCollatorOptions,
): DefaultTechDocsCollator;
// (undocumented)
@@ -23,6 +23,7 @@ import { DefaultTechDocsCollator } from './DefaultTechDocsCollator';
import { msw } from '@backstage/test-utils';
import { setupServer } from 'msw/node';
import { rest } from 'msw';
import { ConfigReader } from '@backstage/config';
const logger = getVoidLogger();
@@ -94,7 +95,12 @@ describe('DefaultTechDocsCollator with legacyPathCasing configuration', () => {
getBaseUrl: jest.fn().mockResolvedValue('http://test-backend'),
getExternalBaseUrl: jest.fn(),
};
collator = new DefaultTechDocsCollator({
const mockConfig = new ConfigReader({
techdocs: {
legacyUseCaseSensitiveTripletPaths: true,
},
});
collator = DefaultTechDocsCollator.fromConfig(mockConfig, {
discovery: mockDiscoveryApi,
logger,
legacyPathCasing: true,
@@ -146,7 +152,7 @@ describe('DefaultTechDocsCollator', () => {
getBaseUrl: jest.fn().mockResolvedValue('http://test-backend'),
getExternalBaseUrl: jest.fn(),
};
collator = new DefaultTechDocsCollator({
collator = DefaultTechDocsCollator.fromConfig(new ConfigReader({}), {
discovery: mockDiscoveryApi,
logger,
});
@@ -76,8 +76,12 @@ export class DefaultTechDocsCollator implements DocumentCollator {
this.legacyPathCasing = legacyPathCasing;
}
static fromConfig(_config: Config, options: TechDocsCollatorOptions) {
return new DefaultTechDocsCollator(options);
static fromConfig(config: Config, options: TechDocsCollatorOptions) {
const legacyPathCasing =
config.getOptionalBoolean(
'techdocs.legacyUseCaseSensitiveTripletPaths',
) || false;
return new DefaultTechDocsCollator({ ...options, legacyPathCasing });
}
async execute() {