From 65596b0cf4a01cb7e6d15d75f809276f53e0d1ec Mon Sep 17 00:00:00 2001 From: Jonathan Mezach Date: Tue, 4 Jul 2023 16:40:43 +0200 Subject: [PATCH] Respond to comments Signed-off-by: Jonathan Mezach --- .changeset/rude-feet-sparkle.md | 4 +- .github/CODEOWNERS | 2 +- plugins/analytics-module-nr/package.json | 6 +-- yarn.lock | 50 +++++++++++------------- 4 files changed, 27 insertions(+), 35 deletions(-) diff --git a/.changeset/rude-feet-sparkle.md b/.changeset/rude-feet-sparkle.md index 09007bd663..96397af1e2 100644 --- a/.changeset/rude-feet-sparkle.md +++ b/.changeset/rude-feet-sparkle.md @@ -1,5 +1,5 @@ --- -'backstage-plugin-analytics-module-nr': patch +'@backstage/plugin-analytics-module-newrelic-browser': patch --- -Initial release +Introduced the New Relic Browser analytics module. Check out the plugins [README.md](https://github.com/backstage/backstage/tree/master/plugins/analytics-module-nr) for more details! diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ea5b656bf7..a2d5f4988a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -17,7 +17,7 @@ /plugins/adr @backstage/maintainers @kuangp /plugins/adr-* @backstage/maintainers @kuangp /plugins/allure @backstage/maintainers @deepak-bhardwaj-ps -/plugins/analytics-module-nr @jmezach +/plugins/analytics-module-nr @backstage/maintainers @jmezach /plugins/apache-airflow @backstage/maintainers @cmpadden /plugins/api-docs @backstage/maintainers @backstage/sda-se-reviewers /plugins/azure-devops @backstage/maintainers @marleypowell @awanlin diff --git a/plugins/analytics-module-nr/package.json b/plugins/analytics-module-nr/package.json index 3cc446150a..6438855070 100644 --- a/plugins/analytics-module-nr/package.json +++ b/plugins/analytics-module-nr/package.json @@ -1,5 +1,5 @@ { - "name": "backstage-plugin-analytics-module-nr", + "name": "@backstage/plugin-analytics-module-newrelic-browser", "version": "0.0.0", "main": "src/index.ts", "types": "src/index.ts", @@ -26,10 +26,6 @@ "@backstage/config": "workspace:^", "@backstage/core-components": "workspace:^", "@backstage/core-plugin-api": "workspace:^", - "@backstage/theme": "workspace:^", - "@material-ui/core": "^4.9.13", - "@material-ui/icons": "^4.9.1", - "@material-ui/lab": "^4.0.0-alpha.60", "@newrelic/browser-agent": "^1.236.0", "react-use": "^17.2.4" }, diff --git a/yarn.lock b/yarn.lock index 1655772dbc..f9fd557d64 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4794,6 +4794,29 @@ __metadata: languageName: unknown linkType: soft +"@backstage/plugin-analytics-module-newrelic-browser@workspace:plugins/analytics-module-nr": + version: 0.0.0-use.local + resolution: "@backstage/plugin-analytics-module-newrelic-browser@workspace:plugins/analytics-module-nr" + dependencies: + "@backstage/cli": "workspace:^" + "@backstage/config": "workspace:^" + "@backstage/core-app-api": "workspace:^" + "@backstage/core-components": "workspace:^" + "@backstage/core-plugin-api": "workspace:^" + "@backstage/dev-utils": "workspace:^" + "@backstage/test-utils": "workspace:^" + "@newrelic/browser-agent": ^1.236.0 + "@testing-library/jest-dom": ^5.10.1 + "@testing-library/react": ^12.1.3 + "@testing-library/user-event": ^14.0.0 + "@types/node": "*" + msw: ^1.0.0 + react-use: ^17.2.4 + peerDependencies: + react: ^16.13.1 || ^17.0.0 + languageName: unknown + linkType: soft + "@backstage/plugin-apache-airflow@workspace:^, @backstage/plugin-apache-airflow@workspace:plugins/apache-airflow": version: 0.0.0-use.local resolution: "@backstage/plugin-apache-airflow@workspace:plugins/apache-airflow" @@ -19928,33 +19951,6 @@ __metadata: languageName: node linkType: hard -"backstage-plugin-analytics-module-nr@workspace:plugins/analytics-module-nr": - version: 0.0.0-use.local - resolution: "backstage-plugin-analytics-module-nr@workspace:plugins/analytics-module-nr" - dependencies: - "@backstage/cli": "workspace:^" - "@backstage/config": "workspace:^" - "@backstage/core-app-api": "workspace:^" - "@backstage/core-components": "workspace:^" - "@backstage/core-plugin-api": "workspace:^" - "@backstage/dev-utils": "workspace:^" - "@backstage/test-utils": "workspace:^" - "@backstage/theme": "workspace:^" - "@material-ui/core": ^4.9.13 - "@material-ui/icons": ^4.9.1 - "@material-ui/lab": ^4.0.0-alpha.60 - "@newrelic/browser-agent": ^1.236.0 - "@testing-library/jest-dom": ^5.10.1 - "@testing-library/react": ^12.1.3 - "@testing-library/user-event": ^14.0.0 - "@types/node": "*" - msw: ^1.0.0 - react-use: ^17.2.4 - peerDependencies: - react: ^16.13.1 || ^17.0.0 - languageName: unknown - linkType: soft - "badge-maker@npm:^3.3.0": version: 3.3.1 resolution: "badge-maker@npm:3.3.1"