unpack props inside component bodies

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

plugins/techdocs-node/api-report.md

@@ -19,10 +19,7 @@ import { Writable } from 'stream';
 
 // @public
 export class DirectoryPreparer implements PreparerBase {
-  static fromConfig(
-    config: Config,
-    { logger, reader }: PreparerConfig,
-  ): DirectoryPreparer;
+  static fromConfig(config: Config, options: PreparerConfig): DirectoryPreparer;
   prepare(entity: Entity, options?: PreparerOptions): Promise<PreparerResponse>;
 }
 
@@ -165,7 +162,7 @@ export type PreparerResponse = {
 export class Preparers implements PreparerBuilder {
   static fromConfig(
     backstageConfig: Config,
-    { logger, reader }: PreparerConfig,
+    options: PreparerConfig,
   ): Promise<PreparerBuilder>;
   get(entity: Entity): PreparerBase;
   register(protocol: RemoteProtocol, preparer: PreparerBase): void;
@@ -175,7 +172,7 @@ export class Preparers implements PreparerBuilder {
 export class Publisher {
   static fromConfig(
     config: Config,
-    { logger, discovery }: PublisherFactory,
+    options: PublisherFactory,
   ): Promise<PublisherBase>;
 }
 
@@ -275,7 +272,7 @@ export const transformDirLocation: (
 
 // @public
 export class UrlPreparer implements PreparerBase {
-  static fromConfig({ reader, logger }: PreparerConfig): UrlPreparer;
+  static fromConfig(options: PreparerConfig): UrlPreparer;
   prepare(entity: Entity, options?: PreparerOptions): Promise<PreparerResponse>;
 }
 ```

plugins/techdocs-node/src/stages/prepare/dir.ts

@@ -46,9 +46,9 @@ export class DirectoryPreparer implements PreparerBase {
    */
   static fromConfig(
     config: Config,
-    { logger, reader }: PreparerConfig,
+    options: PreparerConfig,
   ): DirectoryPreparer {
-    return new DirectoryPreparer(config, logger, reader);
+    return new DirectoryPreparer(config, options.logger, options.reader);
   }
 
   private constructor(

plugins/techdocs-node/src/stages/prepare/preparers.ts

@@ -40,11 +40,14 @@ export class Preparers implements PreparerBuilder {
    */
   static async fromConfig(
     backstageConfig: Config,
-    { logger, reader }: PreparerConfig,
+    options: PreparerConfig,
   ): Promise<PreparerBuilder> {
     const preparers = new Preparers();
 
-    const urlPreparer = UrlPreparer.fromConfig({ reader, logger });
+    const urlPreparer = UrlPreparer.fromConfig({
+      reader: options.reader,
+      logger: options.logger,
+    });
     preparers.register('url', urlPreparer);
 
     /**
@@ -52,8 +55,8 @@ export class Preparers implements PreparerBuilder {
      * When using dir preparer, the docs will be fetched using URL Reader.
      */
     const directoryPreparer = DirectoryPreparer.fromConfig(backstageConfig, {
-      logger,
-      reader,
+      reader: options.reader,
+      logger: options.logger,
     });
     preparers.register('dir', directoryPreparer);
 

plugins/techdocs-node/src/stages/prepare/url.ts

@@ -38,8 +38,8 @@ export class UrlPreparer implements PreparerBase {
    * Returns a directory preparer instance
    * @param config - A URL preparer config containing the a logger and reader
    */
-  static fromConfig({ reader, logger }: PreparerConfig): UrlPreparer {
-    return new UrlPreparer(reader, logger);
+  static fromConfig(options: PreparerConfig): UrlPreparer {
+    return new UrlPreparer(options.reader, options.logger);
   }
 
   private constructor(reader: UrlReader, logger: Logger) {

plugins/techdocs-node/src/stages/publish/publish.ts

@@ -35,8 +35,10 @@ export class Publisher {
    */
   static async fromConfig(
     config: Config,
-    { logger, discovery }: PublisherFactory,
+    options: PublisherFactory,
   ): Promise<PublisherBase> {
+    const { logger, discovery } = options;
+
     const publisherType = (config.getOptionalString(
       'techdocs.publisher.type',
     ) ?? 'local') as PublisherType;