move template edit url to header

Signed-off-by: kosukeKK <koskacts@gmail.com>
This commit is contained in:
kosukeKK
2024-03-02 01:16:21 +09:00
parent 18b4fc7f72
commit 6422f7b45a
4 changed files with 88 additions and 86 deletions
@@ -117,4 +117,68 @@ describe('TemplateWizardPage', () => {
context: { entityRef: 'template:default/test' },
});
});
describe('scaffolder page context menu', () => {
it('should render if editUrl is set to url', async () => {
scaffolderApiMock.getTemplateParameterSchema.mockResolvedValue({
steps: [
{
title: 'Step 1',
schema: {
properties: {
name: {
type: 'string',
},
},
},
},
],
title: 'React JSON Schema Form Test',
editUrl: 'http://example.com/load-testing',
});
const { queryByTestId } = await renderInTestApp(
<ApiProvider apis={apis}>
<SecretsContextProvider>
<TemplateWizardPage customFieldExtensions={[]} />,
</SecretsContextProvider>
</ApiProvider>,
{
mountedRoutes: {
'/create': rootRouteRef,
},
},
);
expect(queryByTestId('menu-button')).toBeInTheDocument();
});
it('should not render if editUrl is undefined', async () => {
scaffolderApiMock.getTemplateParameterSchema.mockResolvedValue({
steps: [
{
title: 'Step 1',
schema: {
properties: {
name: {
type: 'string',
},
},
},
},
],
title: 'React JSON Schema Form Test',
editUrl: undefined,
});
const { queryByTestId } = await renderInTestApp(
<ApiProvider apis={apis}>
<SecretsContextProvider>
<TemplateWizardPage customFieldExtensions={[]} />,
</SecretsContextProvider>
</ApiProvider>,
{
mountedRoutes: {
'/create': rootRouteRef,
},
},
);
expect(queryByTestId('menu-button')).not.toBeInTheDocument();
});
});
});
@@ -30,6 +30,7 @@ import {
FieldExtensionOptions,
ReviewStepProps,
} from '@backstage/plugin-scaffolder-react';
import { ScaffolderPageContextMenu } from '@backstage/plugin-scaffolder-react/alpha';
import { Workflow } from '@backstage/plugin-scaffolder-react/alpha';
import { JsonValue } from '@backstage/types';
import { Header, Page } from '@backstage/core-components';
@@ -73,6 +74,22 @@ export const TemplateWizardPage = (props: TemplateWizardPageProps) => {
name: templateName,
});
const [editUrl, setEditURL] = React.useState('');
scaffolderApi.getTemplateParameterSchema(templateRef).then(data => {
if (data.editUrl !== undefined) setEditURL(data.editUrl);
});
const scaffolderPageContextMenuProps = {
onEditorClicked:
editUrl !== ''
? () => {
window.location.href = editUrl;
}
: undefined,
onActionsClicked: undefined,
onTasksClicked: undefined,
onCreateClicked: undefined,
};
const onCreate = async (values: Record<string, JsonValue>) => {
const { taskId } = await scaffolderApi.scaffold({
templateRef,
@@ -93,7 +110,9 @@ export const TemplateWizardPage = (props: TemplateWizardPageProps) => {
title="Create a new component"
subtitle="Create new software components using standard templates in your organization"
{...props.headerOptions}
/>
>
<ScaffolderPageContextMenu {...scaffolderPageContextMenuProps} />
</Header>
<Workflow
namespace={namespace}
templateName={templateName}