From 638b97584d86ee7fc61527ac70934f9ae4232f50 Mon Sep 17 00:00:00 2001 From: Philipp Hugenroth Date: Thu, 24 Aug 2023 12:05:38 +0200 Subject: [PATCH] Update publishing.md quick patch - forgot to commit the change here : https://github.com/backstage/backstage/pull/19509#pullrequestreview-1589780358 Signed-off-by: Philipp Hugenroth --- docs/publishing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/publishing.md b/docs/publishing.md index 6b4dbfa48d..be94406a40 100644 --- a/docs/publishing.md +++ b/docs/publishing.md @@ -23,7 +23,7 @@ PR is merged. This is typically done every Tuesday around noon CET. - Verify the version we are shipping is correct, by looking at the version packages PR title. It should be "Version Packages (next)" - Check [`.changeset/pre.json`](https://github.com/backstage/backstage/blob/master/.changeset/pre.json) if the `mode` is set to `pre`. If you encounter `mode: "exit"` or if it's not defined, it indicates a mainline release. - Verify that there are no active/unfinished `sync_version-packages` actions running (https://github.com/backstage/backstage/actions/workflows/sync_version-packages.yml) - - Locking the main branch will prevent new ones to be created + - Locking the main branch will prevent new ones to be created, but be sure to check for running actions again after unlocking, since it may cause pending auto-merge PRs to be merged. - Check [`Version Packages (next)` Pull Request](https://github.com/backstage/backstage/pulls?q=is%3Aopen+is%3Apr+in%3Atitle+%22Version+Packages+%28next%29%22) for sufficient approval to be merged - Check generated `changelog` in the changed files of the pull request under `docs/releases` to see if there are any unexpected major bumps e.g. by searching the file - Review & approve changes