From 633d950fe71ca74d68237d3ab6dd77e937cf2e09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Fri, 25 Apr 2025 22:04:34 +0200 Subject: [PATCH] remove CodeOwnersProcessor from the defaults MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .changeset/sad-showers-begin.md | 2 ++ plugins/catalog-backend/package.json | 2 +- plugins/catalog-backend/src/service/CatalogBuilder.ts | 2 -- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/sad-showers-begin.md b/.changeset/sad-showers-begin.md index 3f78400a13..7fce23a2ab 100644 --- a/.changeset/sad-showers-begin.md +++ b/.changeset/sad-showers-begin.md @@ -4,6 +4,8 @@ **BREAKING**: Removed all deprecated exports, and removed support for the old backend system. +It also removes the `CodeOwnersProcessor` from the default set of processors, because it is expensive to run and has vague semantics. You need to update your backend to add it to the `catalogProcessingExtensionPoint` if you wish to continue using it. + The following removed exports are available from `@backstage/plugin-catalog-node`: - `locationSpecToMetadataName` diff --git a/plugins/catalog-backend/package.json b/plugins/catalog-backend/package.json index 58df69f6a3..f2c872e410 100644 --- a/plugins/catalog-backend/package.json +++ b/plugins/catalog-backend/package.json @@ -75,7 +75,6 @@ "@backstage/plugin-permission-node": "workspace:^", "@backstage/types": "workspace:^", "@opentelemetry/api": "^1.9.0", - "@types/express": "^4.17.6", "codeowners-utils": "^1.0.2", "core-js": "^3.6.5", "express": "^4.17.1", @@ -102,6 +101,7 @@ "@backstage/repo-tools": "workspace:^", "@backstage/test-utils": "workspace:^", "@types/core-js": "^2.5.4", + "@types/express": "^4.17.6", "@types/git-url-parse": "^9.0.0", "@types/glob": "^8.0.0", "@types/lodash": "^4.14.151", diff --git a/plugins/catalog-backend/src/service/CatalogBuilder.ts b/plugins/catalog-backend/src/service/CatalogBuilder.ts index 899563c74d..8aa2059209 100644 --- a/plugins/catalog-backend/src/service/CatalogBuilder.ts +++ b/plugins/catalog-backend/src/service/CatalogBuilder.ts @@ -85,7 +85,6 @@ import { DefaultCatalogProcessingOrchestrator } from '../processing/DefaultCatal import { AnnotateLocationEntityProcessor, BuiltinKindsEntityProcessor, - CodeOwnersProcessor, FileReaderProcessor, PlaceholderProcessor, UrlReaderProcessor, @@ -358,7 +357,6 @@ export class CatalogBuilder { return [ new FileReaderProcessor(), new UrlReaderProcessor({ reader, logger, config }), - CodeOwnersProcessor.fromConfig(config, { logger, reader }), new AnnotateLocationEntityProcessor({ integrations }), ]; }