From dce115c3267e07255d5e44b5448f0f7d381b5165 Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Tue, 2 May 2023 11:47:52 +0200 Subject: [PATCH 1/2] include -react packages to a11y CI checks Signed-off-by: Emma Indal --- .github/workflows/verify_accessibility-noop.yml | 12 ++++++++---- .github/workflows/verify_accessibility.yml | 13 ++++++++----- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/.github/workflows/verify_accessibility-noop.yml b/.github/workflows/verify_accessibility-noop.yml index 5db9ecf2a5..bde483eece 100644 --- a/.github/workflows/verify_accessibility-noop.yml +++ b/.github/workflows/verify_accessibility-noop.yml @@ -8,10 +8,14 @@ on: paths-ignore: - 'lighthouserc.js' - '.github/workflows/verify_accessibility_core.yml' - - 'plugins/catalog/**' - - 'plugins/techdocs/**' - - 'plugins/scaffolder/**' - - 'plugins/search/**' + - 'plugins/catalog/src/**' + - 'plugins/catalog-react/src/**' + - 'plugins/techdocs/src/**' + - 'plugins/techdocs-react/src/**' + - 'plugins/scaffolder/src/**' + - 'plugins/scaffolder-react/src/**' + - 'plugins/search/src/**' + - 'plugins/search-react/src/**' jobs: noop: diff --git a/.github/workflows/verify_accessibility.yml b/.github/workflows/verify_accessibility.yml index 6b83495811..cf7b750c54 100644 --- a/.github/workflows/verify_accessibility.yml +++ b/.github/workflows/verify_accessibility.yml @@ -6,11 +6,14 @@ on: paths: - 'lighthouserc.js' - '.github/workflows/verify_accessibility_core.yml' - - 'plugins/catalog/**' - - 'plugins/techdocs/**' - - 'plugins/scaffolder/**' - - 'plugins/search/**' - + - 'plugins/catalog/src/**' + - 'plugins/catalog-react/src/**' + - 'plugins/techdocs/src/**' + - 'plugins/techdocs-react/src/**' + - 'plugins/scaffolder/src/**' + - 'plugins/scaffolder-react/src/**' + - 'plugins/search/src/**' + - 'plugins/search-react/src/**' jobs: lhci: name: Accessibility From c69a32bc0d2ae0a7b22c9327de75f921490d2980 Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Tue, 2 May 2023 11:48:24 +0200 Subject: [PATCH 2/2] increase score to 0.95 Signed-off-by: Emma Indal --- lighthouserc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouserc.js b/lighthouserc.js index 18b2bee5bb..e4bfca5368 100644 --- a/lighthouserc.js +++ b/lighthouserc.js @@ -54,7 +54,7 @@ module.exports = { 'categories:pwa': 'off', 'categories:best-practices': 'off', 'categories:seo': 'off', - 'categories:accessibility': ['error', { minScore: 0.85 }], + 'categories:accessibility': ['error', { minScore: 0.95 }], }, }, },