From 626a71fa06571f8808b1468a9ae930fc8230b0e3 Mon Sep 17 00:00:00 2001 From: Brian Fletcher Date: Wed, 7 Dec 2022 13:03:27 +0000 Subject: [PATCH] fix review comments Signed-off-by: Brian Fletcher --- docs/features/software-catalog/descriptor-format.md | 2 +- docs/features/software-templates/adding-templates.md | 2 +- .../migrating-from-v1beta2-to-v1beta3.md | 10 +++++----- docs/features/software-templates/writing-templates.md | 10 +++++----- .../default-app/examples/template/template.yaml | 2 +- .../scaffolder-backend-module-cookiecutter/README.md | 6 +++--- plugins/scaffolder-backend-module-rails/README.md | 6 +++--- plugins/scaffolder-backend-module-yeoman/README.md | 6 +++--- .../sample-templates/bitbucket-demo/template.yaml | 4 ++-- 9 files changed, 24 insertions(+), 24 deletions(-) diff --git a/docs/features/software-catalog/descriptor-format.md b/docs/features/software-catalog/descriptor-format.md index be71c9d174..6596e65464 100644 --- a/docs/features/software-catalog/descriptor-format.md +++ b/docs/features/software-catalog/descriptor-format.md @@ -703,7 +703,7 @@ spec: name: Register action: catalog:register input: - repoContentsUrl: '{{ steps["publish"].output.repoContentsUrl }}' + repoContentsUrl: {{ steps['publish'].output.repoContentsUrl }} catalogInfoPath: '/catalog-info.yaml' ``` diff --git a/docs/features/software-templates/adding-templates.md b/docs/features/software-templates/adding-templates.md index e11dad2acb..6b0e2330a4 100644 --- a/docs/features/software-templates/adding-templates.md +++ b/docs/features/software-templates/adding-templates.md @@ -76,7 +76,7 @@ spec: name: Register action: catalog:register input: - repoContentsUrl: ${{ steps["publish"].output.repoContentsUrl }} + repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }} catalogInfoPath: '/catalog-info.yaml' ``` diff --git a/docs/features/software-templates/migrating-from-v1beta2-to-v1beta3.md b/docs/features/software-templates/migrating-from-v1beta2-to-v1beta3.md index c36f02a3df..6e37a4df3e 100644 --- a/docs/features/software-templates/migrating-from-v1beta2-to-v1beta3.md +++ b/docs/features/software-templates/migrating-from-v1beta2-to-v1beta3.md @@ -169,14 +169,14 @@ These should be moved to `links` under the `output` object instead. ```diff output: -- remoteUrl: '{{ steps["publish"].output.remoteUrl }}' -- entityRef: '{{ steps["register"].output.entityRef }}' +- remoteUrl: {{ steps['publish'].output.remoteUrl }} +- entityRef: {{ steps['register'].output.entityRef }} + links: + - title: Repository -+ url: ${{ steps["publish"].output.remoteUrl }} ++ url: ${{ steps['publish'].output.remoteUrl }} + - title: Open in catalog + icon: catalog -+ entityRef: ${{ steps["register"].output.entityRef }} ++ entityRef: ${{ steps['register'].output.entityRef }} ``` @@ -206,7 +206,7 @@ Alternatively, it's possible to keep the `dash-case` syntax and use brackets for ```yaml input: - repoUrl: ${{ steps["my-custom-action"].output.repoUrl }} + repoUrl: ${{ steps['my-custom-action'].output.repoUrl }} ``` ### Summary diff --git a/docs/features/software-templates/writing-templates.md b/docs/features/software-templates/writing-templates.md index d53ce3716c..e5fdb034fb 100644 --- a/docs/features/software-templates/writing-templates.md +++ b/docs/features/software-templates/writing-templates.md @@ -88,17 +88,17 @@ spec: name: Register action: catalog:register input: - repoContentsUrl: ${{ steps["publish"].output.repoContentsUrl }} + repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }} catalogInfoPath: '/catalog-info.yaml' # some outputs which are saved along with the job for use in the frontend output: links: - title: Repository - url: ${{ steps["publish"].output.remoteUrl }} + url: ${{ steps['publish'].output.remoteUrl }} - title: Open in catalog icon: catalog - entityRef: ${{ steps["register"].output.entityRef }} + entityRef: ${{ steps['register'].output.entityRef }} ``` Let's dive in and pick apart what each of these sections do and what they are. @@ -505,10 +505,10 @@ The main two that are used are the following: output: links: - title: Repository - url: ${{ steps["publish"].output.remoteUrl }} # link to the remote repository + url: ${{ steps['publish'].output.remoteUrl }} # link to the remote repository - title: Open in catalog icon: catalog - entityRef: ${{ steps["register"].output.entityRef }} # link to the entity that has been ingested to the catalog + entityRef: ${{ steps['register'].output.entityRef }} # link to the entity that has been ingested to the catalog ``` ## The templating syntax diff --git a/packages/create-app/templates/default-app/examples/template/template.yaml b/packages/create-app/templates/default-app/examples/template/template.yaml index 39c5d2326f..be3533162f 100644 --- a/packages/create-app/templates/default-app/examples/template/template.yaml +++ b/packages/create-app/templates/default-app/examples/template/template.yaml @@ -71,4 +71,4 @@ spec: url: ${{ steps["publish"].output.remoteUrl }} - title: Open in catalog icon: catalog - entityRef: ${{ steps["register"].output.entityRef }} + entityRef: ${{ steps['register'].output.entityRef }} diff --git a/plugins/scaffolder-backend-module-cookiecutter/README.md b/plugins/scaffolder-backend-module-cookiecutter/README.md index 642ef25edf..8516139e64 100644 --- a/plugins/scaffolder-backend-module-cookiecutter/README.md +++ b/plugins/scaffolder-backend-module-cookiecutter/README.md @@ -129,7 +129,7 @@ spec: name: Register action: catalog:register input: - repoContentsUrl: ${{ steps.publish.output.repoContentsUrl }} + repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }} catalogInfoPath: '/catalog-info.yaml' - name: Results @@ -141,10 +141,10 @@ spec: output: links: - title: Repository - url: ${{ steps.publish.output.remoteUrl }} + url: ${{ steps['publish'].output.remoteUrl }} - title: Open in catalog icon: catalog - entityRef: ${{ steps.register.output.entityRef }} + entityRef: ${{ steps['register'].output.entityRef }} ``` You can also visit the `/create/actions` route in your Backstage application to find out more about the parameters this action accepts when it's installed to configure how you like. diff --git a/plugins/scaffolder-backend-module-rails/README.md b/plugins/scaffolder-backend-module-rails/README.md index 9d1316473d..738cd43cff 100644 --- a/plugins/scaffolder-backend-module-rails/README.md +++ b/plugins/scaffolder-backend-module-rails/README.md @@ -206,7 +206,7 @@ spec: name: Register action: catalog:register input: - repoContentsUrl: ${{ steps.publish.output.repoContentsUrl }} + repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }} catalogInfoPath: '/catalog-info.yaml' - name: Results @@ -218,10 +218,10 @@ spec: output: links: - title: Repository - url: ${{ steps.publish.output.remoteUrl }} + url: ${{ steps['publish'].output.remoteUrl }} - title: Open in catalog icon: catalog - entityRef: ${{ steps.register.output.entityRef }} + entityRef: ${{ steps['register'].output.entityRef }} ``` ### What you need to run that action diff --git a/plugins/scaffolder-backend-module-yeoman/README.md b/plugins/scaffolder-backend-module-yeoman/README.md index 8ad3a74fe2..5242ef298c 100644 --- a/plugins/scaffolder-backend-module-yeoman/README.md +++ b/plugins/scaffolder-backend-module-yeoman/README.md @@ -126,7 +126,7 @@ spec: name: Register action: catalog:register input: - repoContentsUrl: ${{ steps.publish.output.repoContentsUrl }} + repoContentsUrl: ${{ steps['publish'].output.repoContentsUrl }} catalogInfoPath: '/catalog-info.yaml' - name: Results @@ -138,10 +138,10 @@ spec: output: links: - title: Repository - url: ${{ steps.publish.output.remoteUrl }} + url: ${{ steps['publish'].output.remoteUrl }} - title: Open in catalog icon: catalog - entityRef: ${{ steps.register.output.entityRef }} + entityRef: ${{ steps['register'].output.entityRef }} ``` You can also visit the `/create/actions` route in your Backstage application to find out more about the parameters this action accepts when it's installed to configure how you like. diff --git a/plugins/scaffolder-backend/sample-templates/bitbucket-demo/template.yaml b/plugins/scaffolder-backend/sample-templates/bitbucket-demo/template.yaml index 8fd60b594a..074f74f49d 100644 --- a/plugins/scaffolder-backend/sample-templates/bitbucket-demo/template.yaml +++ b/plugins/scaffolder-backend/sample-templates/bitbucket-demo/template.yaml @@ -74,7 +74,7 @@ spec: output: links: - title: Repository - url: ${{ steps["publish"].output.remoteUrl }} + url: ${{ steps['publish'].output.remoteUrl }} - title: Open in catalog icon: catalog - entityRef: ${{ steps["register"].output.entityRef }} + entityRef: ${{ steps['register'].output.entityRef }}