From 617a7d29c242679b9659ab15944856b85a27a2ca Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Thu, 11 Jul 2024 11:18:18 +0200
Subject: [PATCH] backend-app-api: avoid using service factory options for
 plugin meta service

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .changeset/nice-cats-nail.md                         |  5 +++++
 .../backend-app-api/src/wiring/ServiceRegistry.ts    | 12 ++++++------
 2 files changed, 11 insertions(+), 6 deletions(-)
 create mode 100644 .changeset/nice-cats-nail.md

diff --git a/.changeset/nice-cats-nail.md b/.changeset/nice-cats-nail.md
new file mode 100644
index 0000000000..0e9b1603b8
--- /dev/null
+++ b/.changeset/nice-cats-nail.md
@@ -0,0 +1,5 @@
+---
+'@backstage/backend-app-api': patch
+---
+
+Internal refactor that avoids the use of service factory options.
diff --git a/packages/backend-app-api/src/wiring/ServiceRegistry.ts b/packages/backend-app-api/src/wiring/ServiceRegistry.ts
index 6e20dd98e8..56d8d611bb 100644
--- a/packages/backend-app-api/src/wiring/ServiceRegistry.ts
+++ b/packages/backend-app-api/src/wiring/ServiceRegistry.ts
@@ -48,13 +48,13 @@ function toInternalServiceFactory<TService, TScope extends 'plugin' | 'root'>(
   return f;
 }
 
-const pluginMetadataServiceFactory = createServiceFactory(
-  (options?: { pluginId: string }) => ({
+function createPluginMetadataServiceFactory(pluginId: string) {
+  return createServiceFactory({
     service: coreServices.pluginMetadata,
     deps: {},
-    factory: async () => ({ getId: () => options?.pluginId! }),
-  }),
-);
+    factory: async () => ({ getId: () => pluginId }),
+  });
+}
 
 export class ServiceRegistry {
   static create(factories: Array<ServiceFactory>): ServiceRegistry {
@@ -97,7 +97,7 @@ export class ServiceRegistry {
     // Special case handling of the plugin metadata service, generating a custom factory for it each time
     if (ref.id === coreServices.pluginMetadata.id) {
       return Promise.resolve(
-        toInternalServiceFactory(pluginMetadataServiceFactory({ pluginId })),
+        toInternalServiceFactory(createPluginMetadataServiceFactory(pluginId)),
       );
     }