From 6026ebb680ccae8306b7699c8b02564a60e5b37b Mon Sep 17 00:00:00 2001 From: Radoslaw Wielonski Date: Tue, 7 Dec 2021 12:24:14 +0100 Subject: [PATCH] refactor: use prototype to access private properties and avoid // @ts-ignore Signed-off-by: Radoslaw Wielonski --- .../src/service/lib/ServiceBuilderImpl.test.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/backend-common/src/service/lib/ServiceBuilderImpl.test.ts b/packages/backend-common/src/service/lib/ServiceBuilderImpl.test.ts index 853c7d9a9e..6229cbb683 100644 --- a/packages/backend-common/src/service/lib/ServiceBuilderImpl.test.ts +++ b/packages/backend-common/src/service/lib/ServiceBuilderImpl.test.ts @@ -36,8 +36,15 @@ describe('ServiceBuilderImpl', () => { }); describe('setCustomErrorHandler', () => { + it('check if custom error handler is undefined', () => { + const serviceBuilder = new ServiceBuilderImpl(module); + const serviceBuilderProto = Object.getPrototypeOf(serviceBuilder); + expect(serviceBuilderProto.errorHandler).toBeUndefined(); + }); + it('adds custom error handler', () => { const serviceBuilder = new ServiceBuilderImpl(module); + const serviceBuilderProto = Object.getPrototypeOf(serviceBuilder); const customErrorHandler = ( error: Error, _req: Request, @@ -46,12 +53,8 @@ describe('ServiceBuilderImpl', () => { ) => { next(error); }; - serviceBuilder.setErrorHandler(customErrorHandler); - expect(serviceBuilder.errorHandler).toEqual(customErrorHandler); - }); - it('use default error handler', () => { - const serviceBuilder = new ServiceBuilderImpl(module); - expect(serviceBuilder.errorHandler).toBeUndefined(); + serviceBuilderProto.setErrorHandler(customErrorHandler); + expect(serviceBuilderProto.errorHandler).toEqual(customErrorHandler); }); }); });