From 5fd0e077bc3e38cf98dfb172690b4fcdbab4a1d1 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Wed, 24 Nov 2021 14:01:26 +0100
Subject: [PATCH] chore: adding test for this bug

Signed-off-by: blam <ben@blam.sh>
---
 .../tasks/NunjucksWorkflowRunner.test.ts      | 25 +++++++++++++++++++
 .../tasks/NunjucksWorkflowRunner.ts           |  2 +-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.test.ts b/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.test.ts
index 1f7877791c..b2e2e85a6c 100644
--- a/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.test.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.test.ts
@@ -270,6 +270,31 @@ describe('DefaultWorkflowRunner', () => {
       );
     });
 
+    it('should not try and parse something that is not parsable', async () => {
+      jest.spyOn(logger, 'error');
+      const task = createMockTaskWithSpec({
+        apiVersion: 'scaffolder.backstage.io/v1beta3',
+        steps: [
+          {
+            id: 'test',
+            name: 'name',
+            action: 'jest-mock-action',
+            input: {
+              foo: 'bob',
+            },
+          },
+        ],
+        output: {},
+        parameters: {
+          input: 'BACKSTAGE',
+        },
+      });
+
+      await runner.execute(task);
+
+      expect(logger.error).not.toHaveBeenCalled();
+    });
+
     it('should keep the original types for the input and not parse things that arent meant to be parsed', async () => {
       const task = createMockTaskWithSpec({
         apiVersion: 'scaffolder.backstage.io/v1beta3',
diff --git a/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts b/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts
index 1139ce41c5..5b42eef459 100644
--- a/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts
@@ -148,7 +148,7 @@ export class NunjucksWorkflowRunner implements WorkflowRunner {
               return JSON.parse(templated);
             }
           } catch (ex) {
-            console.error(
+            this.options.logger.error(
               `Failed to parse template string: ${value} with error ${ex.message}`,
             );
           }