chore: Address PR comments

Signed-off-by: Jack Palmer <jackpalmer@spotify.com>

.changeset/proud-starfishes-walk.md

@@ -1,6 +0,0 @@
----
-'@backstage/plugin-permission-backend-module-policy-allow-all': patch
-'@backstage/plugin-permission-backend': patch
----
-
-Moved permissionModuleAllowAllPolicy to @backstage/plugin-permission-backend-module-policy-allow-all

.changeset/tall-items-clap.md

@@ -0,0 +1,6 @@
+---
+'@backstage/plugin-permission-backend-module-allow-all-policy': minor
+'@backstage/plugin-permission-backend': patch
+---
+
+Moved `permissionModuleAllowAllPolicy` to `@backstage/plugin-permission-backend-module-allow-all-policy`

packages/backend-next/package.json

@@ -41,7 +41,7 @@
     "@backstage/plugin-lighthouse-backend": "workspace:^",
     "@backstage/plugin-linguist-backend": "workspace:^",
     "@backstage/plugin-permission-backend": "workspace:^",
-    "@backstage/plugin-permission-backend-module-policy-allow-all": "workspace:^",
+    "@backstage/plugin-permission-backend-module-allow-all-policy": "workspace:^",
     "@backstage/plugin-permission-common": "workspace:^",
     "@backstage/plugin-permission-node": "workspace:^",
     "@backstage/plugin-proxy-backend": "workspace:^",

packages/backend-next/src/index.ts

@@ -19,7 +19,7 @@ import { appPlugin } from '@backstage/plugin-app-backend/alpha';
 import { catalogPlugin } from '@backstage/plugin-catalog-backend/alpha';
 import { kubernetesPlugin } from '@backstage/plugin-kubernetes-backend/alpha';
 import { permissionPlugin } from '@backstage/plugin-permission-backend/alpha';
-import { permissionModuleAllowAllPolicy } from '@backstage/plugin-permission-backend-module-policy-allow-all';
+import { permissionModuleAllowAllPolicy } from '@backstage/plugin-permission-backend-module-allow-all-policy';
 import { scaffolderPlugin } from '@backstage/plugin-scaffolder-backend/alpha';
 import { catalogModuleTemplateKind } from '@backstage/plugin-scaffolder-backend/alpha';
 import { searchModuleCatalogCollator } from '@backstage/plugin-search-backend-module-catalog/alpha';

plugins/permission-backend-module-policy-allow-all/README.md

@@ -1,4 +1,4 @@
-# @backstage/plugin-permission-backend-module-policy-allow-all
+# @backstage/plugin-permission-backend-module-allow-all-policy
 
 The allow all policy backend module for the permission plugin.
 

plugins/permission-backend-module-policy-allow-all/api-report.md

@@ -1,4 +1,4 @@
-## API Report File for "@backstage/plugin-permission-backend-module-policy-allow-all"
+## API Report File for "@backstage/plugin-permission-backend-module-allow-all-policy"
 
 > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
 

plugins/permission-backend-module-policy-allow-all/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "@backstage/plugin-permission-backend-module-policy-allow-all",
+  "name": "@backstage/plugin-permission-backend-module-allow-all-policy",
   "description": "Allow all policy backend module for the permission plugin.",
   "version": "0.0.0",
   "main": "src/index.ts",

plugins/permission-backend-module-policy-allow-all/src/policy.ts

@@ -1,13 +1,3 @@
-import { BackstageIdentityResponse } from '@backstage/plugin-auth-node';
-import {
-  AuthorizeResult,
-  PolicyDecision,
-} from '@backstage/plugin-permission-common';
-import {
-  PermissionPolicy,
-  PolicyQuery,
-} from '@backstage/plugin-permission-node';
-
 /*
  * Copyright 2023 The Backstage Authors
  *
@@ -23,6 +13,17 @@ import {
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+import { BackstageIdentityResponse } from '@backstage/plugin-auth-node';
+import {
+  AuthorizeResult,
+  PolicyDecision,
+} from '@backstage/plugin-permission-common';
+import {
+  PermissionPolicy,
+  PolicyQuery,
+} from '@backstage/plugin-permission-node';
+
 export class AllowAllPermissionPolicy implements PermissionPolicy {
   async handle(
     _request: PolicyQuery,

plugins/permission-backend/src/plugin.ts

@@ -61,7 +61,7 @@ export const permissionPlugin = createBackendPlugin({
         const winstonLogger = loggerToWinstonLogger(logger);
         if (!policies.policy) {
           throw new Error(
-            'No policy module installed! Please install a policy module. If you want to allow all requests, use @backstage/plugin-permission-backend-module-policy-allow-all permissionModuleAllowAllPolicy',
+            'No policy module installed! Please install a policy module. If you want to allow all requests, use @backstage/plugin-permission-backend-module-allow-all-policy permissionModuleAllowAllPolicy',
           );
         }
 

yarn.lock

@@ -8223,9 +8223,9 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@backstage/plugin-permission-backend-module-policy-allow-all@workspace:^, @backstage/plugin-permission-backend-module-policy-allow-all@workspace:plugins/permission-backend-module-policy-allow-all":
+"@backstage/plugin-permission-backend-module-allow-all-policy@workspace:^, @backstage/plugin-permission-backend-module-allow-all-policy@workspace:plugins/permission-backend-module-policy-allow-all":
   version: 0.0.0-use.local
-  resolution: "@backstage/plugin-permission-backend-module-policy-allow-all@workspace:plugins/permission-backend-module-policy-allow-all"
+  resolution: "@backstage/plugin-permission-backend-module-allow-all-policy@workspace:plugins/permission-backend-module-policy-allow-all"
   dependencies:
     "@backstage/backend-common": "workspace:^"
     "@backstage/backend-plugin-api": "workspace:^"
@@ -25833,7 +25833,7 @@ __metadata:
     "@backstage/plugin-lighthouse-backend": "workspace:^"
     "@backstage/plugin-linguist-backend": "workspace:^"
     "@backstage/plugin-permission-backend": "workspace:^"
-    "@backstage/plugin-permission-backend-module-policy-allow-all": "workspace:^"
+    "@backstage/plugin-permission-backend-module-allow-all-policy": "workspace:^"
     "@backstage/plugin-permission-common": "workspace:^"
     "@backstage/plugin-permission-node": "workspace:^"
     "@backstage/plugin-proxy-backend": "workspace:^"