diff --git a/packages/core-components/src/layout/SignInPage/SignInPage.tsx b/packages/core-components/src/layout/SignInPage/SignInPage.tsx index 8e1249f83e..c3139f9316 100644 --- a/packages/core-components/src/layout/SignInPage/SignInPage.tsx +++ b/packages/core-components/src/layout/SignInPage/SignInPage.tsx @@ -167,7 +167,7 @@ export const SingleSignInPage = ({ useMountEffect(() => { if (errorParam) { - setError(new Error(decodeURIComponent(errorParam))); + setError(new Error(errorParam)); } login({ checkExisting: true }); }); diff --git a/packages/core-components/src/layout/SignInPage/providers.tsx b/packages/core-components/src/layout/SignInPage/providers.tsx index 9cb2fa3c9f..c1c3b744c1 100644 --- a/packages/core-components/src/layout/SignInPage/providers.tsx +++ b/packages/core-components/src/layout/SignInPage/providers.tsx @@ -101,10 +101,7 @@ export const useSignInProviders = ( const errorParam = searchParams.get('error'); if (errorParam) { errorApi.post( - new ForwardedError(t('signIn.loginFailed'), { - name: 'Error', - message: decodeURIComponent(errorParam), - }), + new ForwardedError(t('signIn.loginFailed'), new Error(errorParam)), ); } }); diff --git a/plugins/auth-node/src/oauth/createOAuthRouteHandlers.test.ts b/plugins/auth-node/src/oauth/createOAuthRouteHandlers.test.ts index e2155df444..edf816cbee 100644 --- a/plugins/auth-node/src/oauth/createOAuthRouteHandlers.test.ts +++ b/plugins/auth-node/src/oauth/createOAuthRouteHandlers.test.ts @@ -768,9 +768,7 @@ describe('createOAuthRouteHandlers', () => { // Verify that the 'error' search param is set with the encoded error message const errorMessage = redirectUrl.searchParams.get('error'); - expect(errorMessage).toBe( - encodeURIComponent('Auth response is missing cookie nonce'), - ); + expect(errorMessage).toBe('Auth response is missing cookie nonce'); }); }); }); diff --git a/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts b/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts index 46f8fc3eca..53ae4101d3 100644 --- a/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts +++ b/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts @@ -252,7 +252,7 @@ export function createOAuthRouteHandlers( if (state?.flow === 'redirect' && state?.redirectUrl) { const redirectUrl = new URL(state.redirectUrl); - redirectUrl.searchParams.set('error', encodeURIComponent(message)); + redirectUrl.searchParams.set('error', message); // set the error in a cookie and redirect user back to sign in where the error can be rendered res.redirect(redirectUrl.toString());