From 5cf89b373d7993a3488464eaa480ff649611d9e3 Mon Sep 17 00:00:00 2001 From: Ben Vu Date: Thu, 24 Apr 2025 12:09:35 -0400 Subject: [PATCH] move line index logic Signed-off-by: Ben Vu --- packages/core-components/src/components/LogViewer/LogLine.tsx | 3 +-- .../core-components/src/components/LogViewer/RealLogViewer.tsx | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core-components/src/components/LogViewer/LogLine.tsx b/packages/core-components/src/components/LogViewer/LogLine.tsx index 4f888fc68e..c258c27655 100644 --- a/packages/core-components/src/components/LogViewer/LogLine.tsx +++ b/packages/core-components/src/components/LogViewer/LogLine.tsx @@ -177,8 +177,7 @@ export function LogLine({ useEffect(() => { if (lineRef.current && setRowHeight) { - // lineNumber is 1-based but height index is 0-based - setRowHeight(line.lineNumber - 1, lineRef.current.offsetHeight); + setRowHeight(line.lineNumber, lineRef.current.offsetHeight); } }, [line.lineNumber, setRowHeight]); diff --git a/packages/core-components/src/components/LogViewer/RealLogViewer.tsx b/packages/core-components/src/components/LogViewer/RealLogViewer.tsx index 1647e9a925..c3b9d67773 100644 --- a/packages/core-components/src/components/LogViewer/RealLogViewer.tsx +++ b/packages/core-components/src/components/LogViewer/RealLogViewer.tsx @@ -87,7 +87,8 @@ export function RealLogViewer(props: RealLogViewerProps) { function setRowHeight(index: number, size: number) { if (shouldTextWrap && listInstance) { (listInstance as VariableSizeList).resetAfterIndex(0); - heights.current = { ...heights.current, [index]: size }; + // lineNumber is 1-based but index is 0-based + heights.current = { ...heights.current, [index - 1]: size }; } }