From 5b6061ac778eaf5a24deb6e924bab7a7b89189df Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Fri, 10 Apr 2026 16:54:06 +0200 Subject: [PATCH] Address review feedback: zod import path and legacy route ref Use explicit zod/v4 import path in tests, and remove unnecessary convertLegacyRouteRef wrapper in catalog-graph README. Signed-off-by: Patrik Oldsberg Made-with: Cursor --- .../src/schema/createPortableSchema.test.ts | 2 +- plugins/catalog-graph/README-alpha.md | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/frontend-plugin-api/src/schema/createPortableSchema.test.ts b/packages/frontend-plugin-api/src/schema/createPortableSchema.test.ts index 55d5421adb..a763c6e188 100644 --- a/packages/frontend-plugin-api/src/schema/createPortableSchema.test.ts +++ b/packages/frontend-plugin-api/src/schema/createPortableSchema.test.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import { z as zodV4 } from 'zod'; +import { z as zodV4 } from 'zod/v4'; import { createConfigSchema, mergePortableSchemas, diff --git a/plugins/catalog-graph/README-alpha.md b/plugins/catalog-graph/README-alpha.md index 0408849737..67fcf2b4b4 100644 --- a/plugins/catalog-graph/README-alpha.md +++ b/plugins/catalog-graph/README-alpha.md @@ -289,7 +289,6 @@ import { createFrontendModule, PageBlueprint, } from '@backstage/frontend-plugin-api'; -import { convertLegacyRouteRef } from '@backstage/core-compat-api'; import { catalogGraphRouteRef } from '@backstage/plugin-catalog-graph'; export default createFrontendModule({ @@ -298,7 +297,7 @@ export default createFrontendModule({ PageBlueprint.make({ params: { path: '/catalog-graph', - routeRef: convertLegacyRouteRef(catalogGraphRouteRef), + routeRef: catalogGraphRouteRef, loader: () => import('./components').then(m => ), },