Changes based on latest feedback

Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
This commit is contained in:
Andre Wanlin
2023-07-11 06:06:15 -05:00
parent 9395baa824
commit 5b5fde3379
7 changed files with 48 additions and 53 deletions
@@ -14,7 +14,7 @@
* limitations under the License.
*/
import { Typography, PageTheme, PageThemeSelector } from './types';
import { BackstageTypography, PageTheme, PageThemeSelector } from './types';
import { pageTheme as defaultPageThemes } from './pageTheme';
const DEFAULT_HTML_FONT_SIZE = 16;
@@ -33,7 +33,7 @@ export interface BaseThemeOptionsInput<PaletteOptions> {
pageTheme?: Record<string, PageTheme>;
fontFamily?: string;
htmlFontSize?: number;
typography?: Typography;
typography?: BackstageTypography;
}
/**
+1 -1
View File
@@ -23,5 +23,5 @@ export type {
BackstagePaletteAdditions,
PageTheme,
PageThemeSelector,
Typography,
BackstageTypography,
} from './types';
+1 -1
View File
@@ -120,7 +120,7 @@ export type BackstageThemeAdditions = {
*
* @public
*/
export type Typography = {
export type BackstageTypography = {
htmlFontSize: number;
fontFamily: string;
h1: {
+2 -2
View File
@@ -29,7 +29,7 @@ import {
createTheme as createV5Theme,
} from '@mui/material/styles';
import { createBaseThemeOptions } from '../base/createBaseThemeOptions';
import { Typography, PageTheme } from '../base/types';
import { BackstageTypography, PageTheme } from '../base/types';
import { defaultComponentThemes } from '../v5';
import { transformV5ComponentThemesToV4 } from './overrides';
import { SupportedThemes, SupportedVersions, UnifiedTheme } from './types';
@@ -64,7 +64,7 @@ export interface UnifiedThemeOptions {
fontFamily?: string;
htmlFontSize?: number;
components?: ThemeOptionsV5['components'];
typography?: Typography;
typography?: BackstageTypography;
}
/**
+2 -2
View File
@@ -25,7 +25,7 @@ import type {
import {
BackstagePaletteAdditions,
BackstageThemeAdditions,
Typography,
BackstageTypography,
PageTheme,
PageThemeSelector,
} from '../base/types';
@@ -90,7 +90,7 @@ export type SimpleThemeOptions = {
pageTheme?: Record<string, PageTheme>;
fontFamily?: string;
htmlFontSize?: number;
typography?: Typography;
typography?: BackstageTypography;
};
declare module '@material-ui/core/styles/createPalette' {