From 5afd5355466b18571e1b15190bd6324b4ede5d8f Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Tue, 2 Jun 2020 14:00:19 +0200
Subject: [PATCH] github/workflows: split cli build to skip more builds on
 windows

---
 .github/workflows/cli-win.yml | 65 +++++++++++++++++++++++++++++++++++
 .github/workflows/cli.yml     | 12 ++-----
 2 files changed, 68 insertions(+), 9 deletions(-)
 create mode 100644 .github/workflows/cli-win.yml

diff --git a/.github/workflows/cli-win.yml b/.github/workflows/cli-win.yml
new file mode 100644
index 0000000000..33179358c6
--- /dev/null
+++ b/.github/workflows/cli-win.yml
@@ -0,0 +1,65 @@
+name: CLI Test Windows
+
+# Building on windows is really slow, so this workflow is separate from cli.yml and only builds on changes
+# to the cli itself. They're more likely to introduce issues on windows, compared to changes to core and yarn.lock.
+on:
+  pull_request:
+    paths:
+      - '.github/workflows/cli-win.yml'
+      - 'packages/cli/**'
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        os: [windows-latest]
+        node-version: [12.x]
+
+    env:
+      CI: true
+      NODE_OPTIONS: --max-old-space-size=4096
+
+    name: Node ${{ matrix.node-version }} on ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: find location of global yarn cache
+        id: yarn-cache
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+      - name: cache global yarn cache
+        uses: actions/cache@v1
+        with:
+          path: ${{ steps.yarn-cache.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+      - name: use node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: yarn install
+        run: yarn install --frozen-lockfile
+      - run: yarn tsc
+      - run: yarn build
+      - name: verify app and plugin creation
+        working-directory: ${{ runner.temp }}
+        run: node ${{ github.workspace }}/packages/cli/e2e-test/cli-e2e-test.js
+        env:
+          BACKSTAGE_E2E_CLI_TEST: true
+      - name: lint newly created app and plugin
+        run: yarn lint:all
+        working-directory: ${{ runner.temp }}/test-app
+        env:
+          BACKSTAGE_E2E_CLI_TEST: true
+      - name: test newly created app and plugin
+        run: yarn test:all
+        working-directory: ${{ runner.temp }}/test-app
+        env:
+          BACKSTAGE_E2E_CLI_TEST: true
+      - name: e2e test newly created app
+        run: yarn test:e2e:ci
+        working-directory: ${{ runner.temp }}/test-app/packages/app
+        env:
+          PORT: 3001
+          BACKSTAGE_E2E_CLI_TEST: true
diff --git a/.github/workflows/cli.yml b/.github/workflows/cli.yml
index 24ff2a734c..49d90546cf 100644
--- a/.github/workflows/cli.yml
+++ b/.github/workflows/cli.yml
@@ -6,6 +6,7 @@ on:
       - '.github/workflows/cli.yml'
       - 'packages/cli/**'
       - 'packages/core/**'
+      - 'packages/core-api/**'
       - 'yarn.lock'
 
 jobs:
@@ -14,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        os: [ubuntu-latest]
         node-version: [12.x]
 
     env:
@@ -42,15 +43,8 @@ jobs:
         run: yarn install --frozen-lockfile
       - run: yarn tsc
       - run: yarn build
-      - name: verify app and plugin creation on Windows
+      - name: verify app and plugin creation
         working-directory: ${{ runner.temp }}
-        if: runner.os == 'Windows'
-        run: node ${{ github.workspace }}/packages/cli/e2e-test/cli-e2e-test.js
-        env:
-          BACKSTAGE_E2E_CLI_TEST: true
-      - name: verify app and plugin creation on Linux
-        working-directory: ${{ runner.temp }}
-        if: runner.os == 'Linux'
         run: |
           sudo sysctl fs.inotify.max_user_watches=524288
           node ${{ github.workspace }}/packages/cli/e2e-test/cli-e2e-test.js