From 6956ae15476845ac124d940341af9da13c87c027 Mon Sep 17 00:00:00 2001 From: Jonah Back Date: Thu, 7 Oct 2021 13:36:50 -0700 Subject: [PATCH 1/2] fix: add check for existence of lines in jacoco converter Signed-off-by: Jonah Back --- plugins/code-coverage-backend/src/service/converter/jacoco.ts | 2 +- plugins/code-coverage-backend/src/service/converter/types.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/code-coverage-backend/src/service/converter/jacoco.ts b/plugins/code-coverage-backend/src/service/converter/jacoco.ts index be46c5152e..c252c00d4e 100644 --- a/plugins/code-coverage-backend/src/service/converter/jacoco.ts +++ b/plugins/code-coverage-backend/src/service/converter/jacoco.ts @@ -83,7 +83,7 @@ export class Jacoco implements Converter { private extractLines(sourcefile: JacocoSourceFile): ParsedLine[] { const parsed: ParsedLine[] = []; - sourcefile.line.forEach(l => { + sourcefile.line?.forEach(l => { parsed.push({ number: parseInt(l.$.nr, 10), missed_instructions: parseInt(l.$.mi, 10), diff --git a/plugins/code-coverage-backend/src/service/converter/types.ts b/plugins/code-coverage-backend/src/service/converter/types.ts index 978961acb4..90ce25bcf0 100644 --- a/plugins/code-coverage-backend/src/service/converter/types.ts +++ b/plugins/code-coverage-backend/src/service/converter/types.ts @@ -79,7 +79,7 @@ export type JacocoSourceFile = { $: { name: string; }; - line: JacocoLine[]; + line: JacocoLine[] | undefined; }; export type JacocoLine = { $: { From da9241530ab59518de02d1438e686916f4015675 Mon Sep 17 00:00:00 2001 From: Jonah Back Date: Thu, 7 Oct 2021 13:39:02 -0700 Subject: [PATCH 2/2] fix: add check for existence of lines in jacoco converter Signed-off-by: Jonah Back --- .changeset/popular-students-sniff.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/popular-students-sniff.md diff --git a/.changeset/popular-students-sniff.md b/.changeset/popular-students-sniff.md new file mode 100644 index 0000000000..e42d5ef51b --- /dev/null +++ b/.changeset/popular-students-sniff.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-code-coverage-backend': patch +--- + +check for existence of lines property in files