Merge pull request #3205 from spotify/rugvip/lintbump

cli: bump @spotify/eslint-* packages to v9

packages/cli/config/eslint.backend.js

@@ -37,6 +37,10 @@ module.exports = {
   },
   ignorePatterns: ['.eslintrc.js', '**/dist/**', '**/dist-types/**'],
   rules: {
+    // TODO(Rugvip): We need to bump @typescript-eslint to v4 to enable these
+    '@typescript-eslint/no-shadow': 0,
+    '@typescript-eslint/no-redeclare': 0,
+
     'no-console': 0, // Permitted in console programs
     'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()'
     'import/newline-after-import': 'error',

packages/cli/config/eslint.js

@@ -41,6 +41,10 @@ module.exports = {
   },
   ignorePatterns: ['.eslintrc.js', '**/dist/**', '**/dist-types/**'],
   rules: {
+    // TODO(Rugvip): We need to bump @typescript-eslint to v4 to enable these
+    '@typescript-eslint/no-shadow': 0,
+    '@typescript-eslint/no-redeclare': 0,
+
     'import/newline-after-import': 'error',
     'import/no-duplicates': 'warn',
     'import/no-extraneous-dependencies': [

packages/cli/package.json

@@ -38,9 +38,9 @@
     "@rollup/plugin-json": "^4.0.2",
     "@rollup/plugin-node-resolve": "^9.0.0",
     "@rollup/plugin-yaml": "^2.1.1",
-    "@spotify/eslint-config-base": "^8.0.0",
-    "@spotify/eslint-config-react": "^8.0.0",
-    "@spotify/eslint-config-typescript": "^8.0.0",
+    "@spotify/eslint-config-base": "^9.0.0",
+    "@spotify/eslint-config-react": "^9.0.0",
+    "@spotify/eslint-config-typescript": "^9.0.0",
     "@sucrase/webpack-loader": "^2.0.0",
     "@svgr/plugin-jsx": "5.4.x",
     "@svgr/plugin-svgo": "5.4.x",

packages/core-api/src/apis/system/ApiRegistry.ts

@@ -27,7 +27,7 @@ class ApiRegistryBuilder {
   }
 
   build(): ApiRegistry {
-    // eslint-disable-next-line no-use-before-define
+    // eslint-disable-next-line @typescript-eslint/no-use-before-define
     return new ApiRegistry(new Map(this.apis));
   }
 }