From 5a714abfb2e452f37ab498349430d6813c478818 Mon Sep 17 00:00:00 2001 From: Nir Gazit Date: Sun, 10 Jan 2021 13:09:27 +0200 Subject: [PATCH] Fixed ESLint errors --- plugins/kafka-backend/package.json | 9 ++++++++- plugins/kafka-backend/src/service/KafkaApi.ts | 2 +- plugins/kafka/package.json | 5 ++++- .../ConsumerGroupOffsets/useConsumerGroupOffsets.ts | 3 --- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/plugins/kafka-backend/package.json b/plugins/kafka-backend/package.json index fc2ff4ac78..b9c5f89d4f 100644 --- a/plugins/kafka-backend/package.json +++ b/plugins/kafka-backend/package.json @@ -31,14 +31,21 @@ "clean": "backstage-cli clean" }, "dependencies": { + "compression": "^1.7.4", + "cors": "^2.8.5", + "express": "^4.17.1", + "express-promise-router": "^3.0.3", + "helmet": "^4.0.0", "@backstage/backend-common": "^0.4.1", "@backstage/catalog-model": "^0.6.0", "@backstage/config": "^0.1.2", "kafkajs": "^1.16.0-beta.6", - "winston": "^3.2.1" + "winston": "^3.2.1", + "yn": "^4.0.0" }, "devDependencies": { "@backstage/cli": "^0.4.2", + "@types/express": "^4.17.6", "supertest": "^4.0.2" }, "files": [ diff --git a/plugins/kafka-backend/src/service/KafkaApi.ts b/plugins/kafka-backend/src/service/KafkaApi.ts index 8b51b41439..17595fcd12 100644 --- a/plugins/kafka-backend/src/service/KafkaApi.ts +++ b/plugins/kafka-backend/src/service/KafkaApi.ts @@ -60,7 +60,7 @@ export class KafkaApi { await admin.connect(); try { - let groupOffsets = await admin.fetchOffsets({ groupId }); + const groupOffsets = await admin.fetchOffsets({ groupId }); return groupOffsets.map(topicOffset => ({ topic: topicOffset.topic, diff --git a/plugins/kafka/package.json b/plugins/kafka/package.json index 62a79823bf..bdb0c0880e 100644 --- a/plugins/kafka/package.json +++ b/plugins/kafka/package.json @@ -20,13 +20,17 @@ "clean": "backstage-cli clean" }, "dependencies": { + "@backstage/catalog-model": "^0.6.0", "@backstage/core": "^0.4.1", "@backstage/theme": "^0.2.2", + "@backstage/plugin-catalog": "^0.2.7", + "@backstage/plugin-kafka-backend": "^0.1.0", "@material-ui/core": "^4.11.0", "@material-ui/icons": "^4.11.2", "@material-ui/lab": "4.0.0-alpha.45", "lodash": "^4.17.20", "react": "^16.13.1", + "react-router": "6.0.0-beta.0", "react-dom": "^16.13.1", "react-use": "^15.3.3" }, @@ -34,7 +38,6 @@ "@backstage/cli": "^0.4.2", "@backstage/dev-utils": "^0.1.6", "@backstage/test-utils": "^0.1.5", - "@backstage/plugin-kafka-backend": "^0.1.0", "@testing-library/jest-dom": "^5.10.1", "@testing-library/react": "^10.4.1", "@testing-library/user-event": "^12.0.7", diff --git a/plugins/kafka/src/components/ConsumerGroupOffsets/useConsumerGroupOffsets.ts b/plugins/kafka/src/components/ConsumerGroupOffsets/useConsumerGroupOffsets.ts index 9ec0d33b56..575f962b4d 100644 --- a/plugins/kafka/src/components/ConsumerGroupOffsets/useConsumerGroupOffsets.ts +++ b/plugins/kafka/src/components/ConsumerGroupOffsets/useConsumerGroupOffsets.ts @@ -28,7 +28,6 @@ export function useConsumerGroupOffsets(groupId: string) { const groupOffsets = await api.getConsumerGroupOffsets(groupId); const groupWithTopicOffsets = await Promise.all( groupOffsets.map(async ({ topic, partitions }) => { - debugger; const topicOffsets = _.keyBy( await api.getTopicOffsets(topic), partition => partition.id, @@ -49,8 +48,6 @@ export function useConsumerGroupOffsets(groupId: string) { } }, [api, errorApi, groupId]); - debugger; - return [ { loading,