From 5a4fa8859b2e9f1049392f65457f9cac7f1d4ef5 Mon Sep 17 00:00:00 2001
From: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
Date: Thu, 9 Feb 2023 13:29:00 -0600
Subject: [PATCH] Updated LinksGroup to use Link over ListItem

Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
---
 .changeset/stale-houses-push.md                            | 5 +++++
 .../Cards/Group/GroupProfile/GroupProfileCard.stories.tsx  | 2 +-
 plugins/org/src/components/Cards/Meta/LinksGroup.tsx       | 7 +++++--
 3 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/stale-houses-push.md

diff --git a/.changeset/stale-houses-push.md b/.changeset/stale-houses-push.md
new file mode 100644
index 0000000000..53296f3efe
--- /dev/null
+++ b/.changeset/stale-houses-push.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-org': patch
+---
+
+Updated `LinksGroup` to use `Link` over `ListItem` as this makes the links more obvious and follows the pattern already used in the `GroupProfileCard`. Also updated the `GroupProfileCard` `ExtraDetails` story in Storybook to enable the `showLinks` feature whith this off there is no difference between it and the `default` story.
diff --git a/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.stories.tsx b/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.stories.tsx
index cfb3d847a4..f183ab4d8e 100644
--- a/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.stories.tsx
+++ b/plugins/org/src/components/Cards/Group/GroupProfile/GroupProfileCard.stories.tsx
@@ -123,7 +123,7 @@ export const ExtraDetails = () => (
   <EntityProvider entity={extraDetailsEntity}>
     <Grid container spacing={4}>
       <Grid item xs={12} md={4}>
-        <GroupProfileCard variant="gridItem" />
+        <GroupProfileCard variant="gridItem" showLinks />
       </Grid>
     </Grid>
   </EntityProvider>
diff --git a/plugins/org/src/components/Cards/Meta/LinksGroup.tsx b/plugins/org/src/components/Cards/Meta/LinksGroup.tsx
index eeade18411..dfc654c14b 100644
--- a/plugins/org/src/components/Cards/Meta/LinksGroup.tsx
+++ b/plugins/org/src/components/Cards/Meta/LinksGroup.tsx
@@ -23,6 +23,7 @@ import {
   Divider,
 } from '@material-ui/core';
 import React from 'react';
+import { Link } from '@backstage/core-components';
 
 const WebLink = ({
   href,
@@ -33,9 +34,11 @@ const WebLink = ({
   text?: string;
   Icon?: IconComponent;
 }) => (
-  <ListItem button component="a" key={href} href={href}>
+  <ListItem key={href}>
     <ListItemIcon>{Icon ? <Icon /> : <LanguageIcon />}</ListItemIcon>
-    <ListItemText>{text}</ListItemText>
+    <ListItemText>
+      <Link to={href}>{text}</Link>
+    </ListItemText>
   </ListItem>
 );