refactor: migrate from deprecated database manager

Changes:
- Swaps out `SingleConnectionDatabaseManager` to `DatabaseManager`
  across the repo.
- Updates `backend-test-utils` to generate test plugin names prefixed
  with db to satisfy plugin naming constraint, e.g. 0 becomes db0.

Signed-off-by: Minn Soe <contributions@minn.io>

packages/backend-test-utils/src/database/TestDatabases.test.ts

@@ -71,7 +71,7 @@ describe('TestDatabases', () => {
         await input.insert({ x: 'y' }).into('a');
 
         // Look for the mark
-        const database = 'backstage_plugin_0';
+        const database = 'backstage_plugin_db0';
         const output = knexFactory({
           client: 'pg',
           connection: { host, port, user, password, database },
@@ -105,7 +105,7 @@ describe('TestDatabases', () => {
         await input.insert({ x: 'y' }).into('a');
 
         // Look for the mark
-        const database = 'backstage_plugin_0';
+        const database = 'backstage_plugin_db0';
         const output = knexFactory({
           client: 'pg',
           connection: { host, port, user, password, database },
@@ -139,7 +139,7 @@ describe('TestDatabases', () => {
         await input.insert({ x: 'y' }).into('a');
 
         // Look for the mark
-        const database = 'backstage_plugin_0';
+        const database = 'backstage_plugin_db0';
         const output = knexFactory({
           client: 'mysql2',
           connection: { host, port, user, password, database },

packages/backend-test-utils/src/database/TestDatabases.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { SingleConnectionDatabaseManager } from '@backstage/backend-common';
+import { DatabaseManager } from '@backstage/backend-common';
 import { ConfigReader } from '@backstage/config';
 import { Knex } from 'knex';
 import { isDockerDisabledForTests } from '../util/isDockerDisabledForTests';
@@ -142,7 +142,7 @@ export class TestDatabases {
 
     // Ensure that a unique logical database is created in the instance
     const connection = await instance.databaseManager
-      .forPlugin(String(this.lastDatabaseIndex++))
+      .forPlugin(String(`db${this.lastDatabaseIndex++}`))
       .getClient();
 
     instance.connections.push(connection);
@@ -157,7 +157,7 @@ export class TestDatabases {
       if (envVarName) {
         const connectionString = process.env[envVarName];
         if (connectionString) {
-          const databaseManager = SingleConnectionDatabaseManager.fromConfig(
+          const databaseManager = DatabaseManager.fromConfig(
             new ConfigReader({
               backend: {
                 database: {
@@ -195,7 +195,7 @@ export class TestDatabases {
       properties.dockerImageName!,
     );
 
-    const databaseManager = SingleConnectionDatabaseManager.fromConfig(
+    const databaseManager = DatabaseManager.fromConfig(
       new ConfigReader({
         backend: {
           database: {
@@ -220,7 +220,7 @@ export class TestDatabases {
       properties.dockerImageName!,
     );
 
-    const databaseManager = SingleConnectionDatabaseManager.fromConfig(
+    const databaseManager = DatabaseManager.fromConfig(
       new ConfigReader({
         backend: {
           database: {
@@ -241,7 +241,7 @@ export class TestDatabases {
   private async initSqlite(
     _properties: TestDatabaseProperties,
   ): Promise<Instance> {
-    const databaseManager = SingleConnectionDatabaseManager.fromConfig(
+    const databaseManager = DatabaseManager.fromConfig(
       new ConfigReader({
         backend: {
           database: {

packages/backend-test-utils/src/database/types.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { SingleConnectionDatabaseManager } from '@backstage/backend-common';
+import { DatabaseManager } from '@backstage/backend-common';
 import { Knex } from 'knex';
 
 /**
@@ -35,10 +35,9 @@ export type TestDatabaseProperties = {
 
 export type Instance = {
   stopContainer?: () => Promise<void>;
-  databaseManager: SingleConnectionDatabaseManager;
+  databaseManager: DatabaseManager;
   connections: Array<Knex>;
 };
-
 export const allDatabases: Record<
   TestDatabaseId,
   TestDatabaseProperties