From ee03f6a73048f7818ee5bbe0fe3d580f6ebaba8b Mon Sep 17 00:00:00 2001 From: Andre Wanlin Date: Mon, 11 Mar 2024 12:43:43 +0100 Subject: [PATCH 1/2] Updated MUI imports for core-components Signed-off-by: Andre Wanlin --- packages/core-components/.eslintrc.js | 1 + .../src/components/AlertDisplay/AlertDisplay.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/core-components/.eslintrc.js b/packages/core-components/.eslintrc.js index 2ebb50e64f..505ea657a2 100644 --- a/packages/core-components/.eslintrc.js +++ b/packages/core-components/.eslintrc.js @@ -1,6 +1,7 @@ module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { rules: { 'jest/expect-expect': 0, + '@backstage/no-top-level-material-ui-4-imports': 'error', }, restrictedImports: [ { diff --git a/packages/core-components/src/components/AlertDisplay/AlertDisplay.tsx b/packages/core-components/src/components/AlertDisplay/AlertDisplay.tsx index 0291b6861d..61876bd58b 100644 --- a/packages/core-components/src/components/AlertDisplay/AlertDisplay.tsx +++ b/packages/core-components/src/components/AlertDisplay/AlertDisplay.tsx @@ -19,7 +19,7 @@ import IconButton from '@material-ui/core/IconButton'; import Snackbar from '@material-ui/core/Snackbar'; import Typography from '@material-ui/core/Typography'; import CloseIcon from '@material-ui/icons/Close'; -import { Alert } from '@material-ui/lab'; +import Alert from '@material-ui/lab/Alert'; import React, { useEffect, useState } from 'react'; import { coreComponentsTranslationRef } from '../../translation'; From 0c9d5eabfe5e5dc83c96e27cc334f598365f047c Mon Sep 17 00:00:00 2001 From: Andre Wanlin Date: Mon, 11 Mar 2024 12:47:48 +0100 Subject: [PATCH 2/2] Added changeset Signed-off-by: Andre Wanlin --- .changeset/moody-waves-wait.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/moody-waves-wait.md diff --git a/.changeset/moody-waves-wait.md b/.changeset/moody-waves-wait.md new file mode 100644 index 0000000000..144b5b4b5e --- /dev/null +++ b/.changeset/moody-waves-wait.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Updated MUI imports for core-components to not be top level