Fix tests

Signed-off-by: shmaram <shaharshmaram@gmail.com>

plugins/home/src/api/config.test.ts

@@ -0,0 +1,84 @@
+/*
+ * Copyright 2023 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { readFilterByConfig, readFilterByConfigs } from './config';
+import { MockConfigApi } from '@backstage/test-utils';
+
+describe('config', () => {
+  describe('readFilterByConfig', () => {
+    it('returns filter data', async () => {
+      const mockConfig = new MockConfigApi(
+        {
+          field: 'pathname',
+          operator: '==',
+          value: '3'
+        });
+      const res = readFilterByConfig(mockConfig)
+      expect(res).toEqual({
+        field: 'pathname',
+        operator: '==',
+        value: '3'
+      })
+    });
+
+    it('throws an error for invalid filter', async () => {
+      const mockConfig = new MockConfigApi(
+        {
+          myField: 'pathname',
+          operator: '==',
+          value: '3'
+        });
+      expect(() => readFilterByConfig(mockConfig)).toThrow('Invalid config, Error: Missing required config value at \'field\'')
+    });
+  });
+
+  describe('readFilterByConfigs', () => {
+    it('returns filter data', async () => {
+      const mockConfig1 = new MockConfigApi(
+        {
+            field: 'id',
+            operator: '==',
+            value: '3'
+          });
+      const mockConfig2 = new MockConfigApi(
+        {
+            field: 'pathname',
+            operator: '==',
+            value: 'path'
+          });
+      const res = readFilterByConfigs([mockConfig1, mockConfig2])
+      expect(res).toEqual([{"field": "id", "operator": "==", "value": "3"}, {"field": "pathname", "operator": "==", "value": "path"}])
+    });
+
+    it('return undefined for invalid filter', async () => {
+      const mockConfig1 = new MockConfigApi(
+        {
+          field: 'id',
+          operator: '==',
+          value: '3'
+        });
+      const mockConfig2 = new MockConfigApi(
+        {
+          myField: 'pathname',
+          operator: '==',
+          value: 'path'
+        });
+      const res = readFilterByConfigs([mockConfig1, mockConfig2])
+      expect(res).toEqual(undefined)
+    });
+  });
+});
+

plugins/home/src/api/config.ts

@@ -55,6 +55,11 @@ export function readFilterByConfig(config: Config): {
  */
 export function readFilterByConfigs(
   configs: Config[],
-): VisitsApiQueryParams['filterBy'] {
-  return configs.map(readFilterByConfig);
+): VisitsApiQueryParams['filterBy'] | undefined {
+  try {
+    return configs.map(readFilterByConfig);
+  }
+  catch {
+    return undefined;
+  }
 }