From 578148ba0e7b3256de7d7f115db663a28f668a35 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Fri, 22 Apr 2022 15:56:31 +0200 Subject: [PATCH] Remove postgres question from e2e tests Signed-off-by: Johan Haals --- .../default-app/packages/backend/package.json.hbs | 6 +++--- packages/e2e-test/src/commands/run.ts | 11 +---------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/packages/create-app/templates/default-app/packages/backend/package.json.hbs b/packages/create-app/templates/default-app/packages/backend/package.json.hbs index acfd465b67..c162dd880e 100644 --- a/packages/create-app/templates/default-app/packages/backend/package.json.hbs +++ b/packages/create-app/templates/default-app/packages/backend/package.json.hbs @@ -41,12 +41,12 @@ "winston": "^3.2.1" }, "devDependencies": { - "better-sqlite3": "^7.5.0", "@backstage/cli": "^{{version '@backstage/cli'}}", "@types/dockerode": "^3.3.0", - "@types/express": "^4.17.6", "@types/express-serve-static-core": "^4.17.5", - "@types/luxon": "^2.0.4" + "@types/express": "^4.17.6", + "@types/luxon": "^2.0.4", + "better-sqlite3": "^7.5.0" }, "files": [ "dist" diff --git a/packages/e2e-test/src/commands/run.ts b/packages/e2e-test/src/commands/run.ts index dc257c6f29..b6df9f61dd 100644 --- a/packages/e2e-test/src/commands/run.ts +++ b/packages/e2e-test/src/commands/run.ts @@ -51,7 +51,7 @@ export async function run() { const isPostgres = Boolean(process.env.POSTGRES_USER); print('Creating a Backstage App'); - const appDir = await createApp('test-app', isPostgres, workspaceDir, rootDir); + const appDir = await createApp('test-app', workspaceDir, rootDir); print('Creating a Backstage Plugin'); const pluginName = await createPlugin('test-plugin', appDir); @@ -191,7 +191,6 @@ async function pinYarnVersion(dir: string) { */ async function createApp( appName: string, - isPostgres: boolean, workspaceDir: string, rootDir: string, ) { @@ -215,14 +214,6 @@ async function createApp( await waitFor(() => stdout.includes('Enter a name for the app')); child.stdin?.write(`${appName}\n`); - await waitFor(() => stdout.includes('Select database for the backend')); - - if (isPostgres) { - // Simulate down arrow press - child.stdin?.write(`\u001B\u005B\u0042`); - } - child.stdin?.write(`\n`); - print('Waiting for app create script to be done'); await waitForExit(child);