From 576c8b07abc3beeece07bb064d7e5d477b5b658a Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 5 Jun 2020 01:16:49 +0200
Subject: [PATCH] packages/cli: always treat nodejs builtins as external, bit
 disallow infrontend code

---
 packages/cli/.eslintrc.js               | 2 +-
 packages/cli/config/eslint.js           | 1 +
 packages/cli/src/lib/packager/config.ts | 1 +
 packages/config-loader/.eslintrc.js     | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/cli/.eslintrc.js b/packages/cli/.eslintrc.js
index 4ae4e8d91b..69bec6cd2a 100644
--- a/packages/cli/.eslintrc.js
+++ b/packages/cli/.eslintrc.js
@@ -1,5 +1,5 @@
 module.exports = {
-  extends: [require.resolve('@backstage/cli/config/eslint')],
+  extends: [require.resolve('@backstage/cli/config/eslint.backend')],
   ignorePatterns: ['templates/**'],
   rules: {
     'no-console': 0,
diff --git a/packages/cli/config/eslint.js b/packages/cli/config/eslint.js
index 922867ea5a..9c461a1b24 100644
--- a/packages/cli/config/eslint.js
+++ b/packages/cli/config/eslint.js
@@ -67,6 +67,7 @@ module.exports = {
             name: '@material-ui/icons',
             message: "Please import '@material-ui/icons/<Icon>' instead.",
           },
+          ...require('module').builtinModules,
         ],
       },
     ],
diff --git a/packages/cli/src/lib/packager/config.ts b/packages/cli/src/lib/packager/config.ts
index bbc3f77916..9d60fa09f4 100644
--- a/packages/cli/src/lib/packager/config.ts
+++ b/packages/cli/src/lib/packager/config.ts
@@ -72,6 +72,7 @@ export const makeConfigs = async (
       input: 'src/index.ts',
       output,
       preserveEntrySignatures: 'strict',
+      external: require('module').builtinModules,
       plugins: [
         peerDepsExternal({
           includeDependencies: true,
diff --git a/packages/config-loader/.eslintrc.js b/packages/config-loader/.eslintrc.js
index 13573efa9c..16a033dbc6 100644
--- a/packages/config-loader/.eslintrc.js
+++ b/packages/config-loader/.eslintrc.js
@@ -1,3 +1,3 @@
 module.exports = {
-  extends: [require.resolve('@backstage/cli/config/eslint')],
+  extends: [require.resolve('@backstage/cli/config/eslint.backend')],
 };