From 5710e3ee8a72255d8cc19764523a0dd96626b207 Mon Sep 17 00:00:00 2001 From: Marley Powell Date: Wed, 30 Mar 2022 15:31:21 +0100 Subject: [PATCH] refactor: Small code review change Signed-off-by: Marley Powell --- .../src/api/PullRequestsDashboardProvider.ts | 4 ++-- plugins/azure-devops-backend/src/service/router.ts | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/azure-devops-backend/src/api/PullRequestsDashboardProvider.ts b/plugins/azure-devops-backend/src/api/PullRequestsDashboardProvider.ts index 655dfe5041..43b4807e7d 100644 --- a/plugins/azure-devops-backend/src/api/PullRequestsDashboardProvider.ts +++ b/plugins/azure-devops-backend/src/api/PullRequestsDashboardProvider.ts @@ -35,10 +35,10 @@ export class PullRequestsDashboardProvider { private readonly azureDevOpsApi: AzureDevOpsApi, ) {} - public static create( + public static async create( logger: Logger, azureDevOpsApi: AzureDevOpsApi, - ): PullRequestsDashboardProvider { + ): Promise { const provider = new PullRequestsDashboardProvider(logger, azureDevOpsApi); return provider; } diff --git a/plugins/azure-devops-backend/src/service/router.ts b/plugins/azure-devops-backend/src/service/router.ts index bb4baabfd3..f41209e4ff 100644 --- a/plugins/azure-devops-backend/src/service/router.ts +++ b/plugins/azure-devops-backend/src/service/router.ts @@ -53,10 +53,8 @@ export async function createRouter( const azureDevOpsApi = options.azureDevOpsApi || new AzureDevOpsApi(logger, webApi); - const pullRequestsDashboardProvider = PullRequestsDashboardProvider.create( - logger, - azureDevOpsApi, - ); + const pullRequestsDashboardProvider = + await PullRequestsDashboardProvider.create(logger, azureDevOpsApi); const router = Router(); router.use(express.json());