From 5691532f891d4861e9874d56c36c6e9f1c45dc3f Mon Sep 17 00:00:00 2001 From: Brian Leathem Date: Wed, 24 Mar 2021 20:54:54 -0700 Subject: [PATCH] Changed the signature of createRoutableExtension to include null Signed-off-by: Brian Leathem --- packages/core-api/src/extensions/extensions.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/core-api/src/extensions/extensions.tsx b/packages/core-api/src/extensions/extensions.tsx index c486bfd84a..191e4c4fb7 100644 --- a/packages/core-api/src/extensions/extensions.tsx +++ b/packages/core-api/src/extensions/extensions.tsx @@ -27,8 +27,11 @@ type ComponentLoader = sync: T; }; +// We do not use ComponentType as the return type, since it doesn't let us convey the children prop. +// ComponentType inserts children as an optional prop whether the inner component accepts it or not, +// making it impossible to make the usage of children type safe. export function createRoutableExtension< - T extends (props: any) => JSX.Element + T extends (props: any) => JSX.Element | null >(options: { component: () => Promise; mountPoint: RouteRef; @@ -70,6 +73,9 @@ export function createComponentExtension< return createReactExtension({ component }); } +// We do not use ComponentType as the return type, since it doesn't let us convey the children prop. +// ComponentType inserts children as an optional prop whether the inner component accepts it or not, +// making it impossible to make the usage of children type safe. export function createReactExtension< T extends (props: any) => JSX.Element | null >(options: {