BREAKING CHANGE: no longer add express.json() by default to backend

plugins/auth-backend/package.json

@@ -23,7 +23,6 @@
     "@backstage/backend-common": "^0.1.1-alpha.20",
     "@backstage/config": "^0.1.1-alpha.20",
     "@types/express": "^4.17.6",
-    "body-parser": "^1.19.0",
     "compression": "^1.7.4",
     "cookie-parser": "^1.4.5",
     "cors": "^2.8.5",

plugins/auth-backend/src/service/router.ts

@@ -17,7 +17,6 @@
 import express from 'express';
 import Router from 'express-promise-router';
 import cookieParser from 'cookie-parser';
-import bodyParser from 'body-parser';
 import Knex from 'knex';
 import { Logger } from 'winston';
 import { createAuthProviderRouter } from '../providers';
@@ -53,8 +52,8 @@ export async function createRouter(
   });
 
   router.use(cookieParser());
-  router.use(bodyParser.urlencoded({ extended: false }));
-  router.use(bodyParser.json());
+  router.use(express.urlencoded({ extended: false }));
+  router.use(express.json());
 
   const providersConfig = options.config.getConfig('auth.providers');
   const providers = providersConfig.keys();

plugins/graphql/src/service/router.ts

@@ -39,8 +39,8 @@ export async function createRouter(
   const server = new ApolloServer({ typeDefs, logger: options.logger });
   const router = Router();
 
-  const apolloMiddlware = server.getMiddleware({ path: '/' });
-  router.use(apolloMiddlware);
+  const apolloMiddleware = server.getMiddleware({ path: '/' });
+  router.use(apolloMiddleware);
 
   router.get('/health', (_, response) => {
     response.send({ status: 'ok' });

plugins/identity-backend/src/service/router.ts

@@ -27,13 +27,15 @@ export interface RouterOptions {
 
 const makeRouter = (adapter: IdentityApi): express.Router => {
   const router = Router();
+  router.use(express.json());
+
   router.get('/users/:user/groups', async (req, res) => {
     const user = req.params.user;
     const type = req.query.type?.toString() ?? '';
-
     const response = await adapter.getUserGroups({ user, type });
     res.send(response);
   });
+
   return router;
 };
 

plugins/rollbar-backend/src/service/router.ts

@@ -31,6 +31,7 @@ export async function createRouter(
   options: RouterOptions,
 ): Promise<express.Router> {
   const router = Router();
+
   const logger = options.logger.child({ plugin: 'rollbar' });
   const config = options.config.getConfig('rollbar');
   const accessToken = !options.rollbarApi

plugins/scaffolder-backend/src/service/router.ts

@@ -42,6 +42,7 @@ export async function createRouter(
   options: RouterOptions,
 ): Promise<express.Router> {
   const router = Router();
+  router.use(express.json());
 
   const {
     preparers,

plugins/sentry-backend/src/service/router.ts

@@ -20,6 +20,8 @@ import { getSentryApiForwarder } from './sentry-api';
 
 export async function createRouter(logger: Logger): Promise<express.Router> {
   const router = Router();
+  router.use(express.json());
+
   const SENTRY_TOKEN = process.env.SENTRY_TOKEN;
   if (!SENTRY_TOKEN) {
     if (process.env.NODE_ENV !== 'development') {