From 56391bd3a4ff0a45e27a114eb676f8862a538acd Mon Sep 17 00:00:00 2001
From: Philipp Hugenroth <philipph@spotify.com>
Date: Mon, 26 Jul 2021 17:07:39 +0200
Subject: [PATCH] Add missing labels

- Adjust Storybook use of sidebar

- Revert a wrong sidebar change

Signed-off-by: Philipp Hugenroth <philipph@spotify.com>
---
 packages/core-components/src/components/Table/Table.tsx    | 4 +++-
 packages/core-components/src/layout/Sidebar/Items.tsx      | 7 +------
 .../core-components/src/layout/Sidebar/Sidebar.stories.tsx | 2 +-
 .../catalog/src/components/CatalogTable/CatalogTable.tsx   | 4 ++--
 4 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/packages/core-components/src/components/Table/Table.tsx b/packages/core-components/src/components/Table/Table.tsx
index d8db602e93..f518a84d52 100644
--- a/packages/core-components/src/components/Table/Table.tsx
+++ b/packages/core-components/src/components/Table/Table.tsx
@@ -491,7 +491,9 @@ export function Table<T extends object = {}>({
         icons={tableIcons}
         title={
           <>
-            <Typography variant="h5">{title}</Typography>
+            <Typography variant="h5" component="h3">
+              {title}
+            </Typography>
             {subtitle && (
               <Typography color="textSecondary" variant="body1">
                 {subtitle}
diff --git a/packages/core-components/src/layout/Sidebar/Items.tsx b/packages/core-components/src/layout/Sidebar/Items.tsx
index 1a7b4ebdb5..d027b55505 100644
--- a/packages/core-components/src/layout/Sidebar/Items.tsx
+++ b/packages/core-components/src/layout/Sidebar/Items.tsx
@@ -262,12 +262,7 @@ export const SidebarSearchField = (props: SidebarSearchFieldProps) => {
 
   return (
     <div className={classes.searchRoot}>
-      <SidebarItem
-        icon={SearchIcon}
-        to={props.to}
-        onClick={handleItemClick}
-        text="Search"
-      >
+      <SidebarItem icon={SearchIcon} to={props.to} onClick={handleItemClick}>
         <TextField
           placeholder="Search"
           value={input}
diff --git a/packages/core-components/src/layout/Sidebar/Sidebar.stories.tsx b/packages/core-components/src/layout/Sidebar/Sidebar.stories.tsx
index 40921a8159..aee5c70b43 100644
--- a/packages/core-components/src/layout/Sidebar/Sidebar.stories.tsx
+++ b/packages/core-components/src/layout/Sidebar/Sidebar.stories.tsx
@@ -44,7 +44,7 @@ const handleSearch = (input: string) => {
 
 export const SampleSidebar = () => (
   <Sidebar>
-    <SidebarSearchField onSearch={handleSearch} />
+    <SidebarSearchField onSearch={handleSearch} to="/search" />
     <SidebarDivider />
     <SidebarItem icon={HomeOutlinedIcon} to="#" text="Home" />
     <SidebarItem icon={HomeOutlinedIcon} to="#" text="Plugins" />
diff --git a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
index 31a9457e2b..86e95b48e0 100644
--- a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
+++ b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
@@ -80,7 +80,7 @@ export const CatalogTable = ({ columns, actions }: CatalogTableProps) => {
     ({ entity }) => {
       const url = getEntityMetadataViewUrl(entity);
       return {
-        icon: () => <OpenInNew fontSize="small" />,
+        icon: () => <OpenInNew aria-label="View" fontSize="small" />,
         tooltip: 'View',
         disabled: !url,
         onClick: () => {
@@ -92,7 +92,7 @@ export const CatalogTable = ({ columns, actions }: CatalogTableProps) => {
     ({ entity }) => {
       const url = getEntityMetadataEditUrl(entity);
       return {
-        icon: () => <Edit fontSize="small" />,
+        icon: () => <Edit aria-label="Edit" fontSize="small" />,
         tooltip: 'Edit',
         disabled: !url,
         onClick: () => {