From 54d3fdb338ac87a5da5f75e91f909c594fb2cb81 Mon Sep 17 00:00:00 2001 From: Eric Peterson Date: Wed, 26 May 2021 17:07:45 +0200 Subject: [PATCH] Allow bundled files to be downloaded by respecting a[download] Signed-off-by: Eric Peterson --- .../techdocs/src/reader/transformers/addBaseUrl.test.ts | 7 +++++++ plugins/techdocs/src/reader/transformers/addBaseUrl.ts | 1 + 2 files changed, 8 insertions(+) diff --git a/plugins/techdocs/src/reader/transformers/addBaseUrl.test.ts b/plugins/techdocs/src/reader/transformers/addBaseUrl.test.ts index 4311de5dae..afed2eff73 100644 --- a/plugins/techdocs/src/reader/transformers/addBaseUrl.test.ts +++ b/plugins/techdocs/src/reader/transformers/addBaseUrl.test.ts @@ -37,6 +37,7 @@ const fixture = ` + Download Now `; @@ -78,5 +79,11 @@ describe('addBaseUrl', () => { mockEntityId, '', ); + expect(techdocsStorageApi.getBaseUrl).toHaveBeenNthCalledWith( + 4, + 'afile.pdf', + mockEntityId, + '', + ); }); }); diff --git a/plugins/techdocs/src/reader/transformers/addBaseUrl.ts b/plugins/techdocs/src/reader/transformers/addBaseUrl.ts index 9cd11f0903..9bb5418bc2 100644 --- a/plugins/techdocs/src/reader/transformers/addBaseUrl.ts +++ b/plugins/techdocs/src/reader/transformers/addBaseUrl.ts @@ -48,6 +48,7 @@ export const addBaseUrl = ({ updateDom(dom.querySelectorAll('img'), 'src'); updateDom(dom.querySelectorAll('script'), 'src'); updateDom(dom.querySelectorAll('link'), 'href'); + updateDom(dom.querySelectorAll('a[download]'), 'href'); return dom; };