From 073b2ebf638851d28dc8f1434d0b36f94eebfaf6 Mon Sep 17 00:00:00 2001
From: Beth Griggs <bethanyngriggs@gmail.com>
Date: Fri, 3 May 2024 15:21:32 +0100
Subject: [PATCH 1/2] chore(test): increase test coverage of WinstonLogger

Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
---
 .../src/logging/WinstonLogger.test.ts         | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/packages/backend-app-api/src/logging/WinstonLogger.test.ts b/packages/backend-app-api/src/logging/WinstonLogger.test.ts
index c7173b1cbe..bec6a9fc0f 100644
--- a/packages/backend-app-api/src/logging/WinstonLogger.test.ts
+++ b/packages/backend-app-api/src/logging/WinstonLogger.test.ts
@@ -22,6 +22,17 @@ function msg(info: TransformableInfo): TransformableInfo {
 }
 
 describe('WinstonLogger', () => {
+  it('creates a winston logger instance with default options', () => {
+    const logger = WinstonLogger.create({});
+    expect(logger).toBeInstanceOf(WinstonLogger);
+  });
+
+  it('creates a child logger', () => {
+    const logger = WinstonLogger.create({});
+    const childLogger = logger.child({ plugin: 'test-plugin' });
+    expect(childLogger).toBeInstanceOf(WinstonLogger);
+  });
+
   it('redacter should redact and escape regex', () => {
     const redacter = WinstonLogger.redacter();
     const log = {
@@ -47,4 +58,24 @@ describe('WinstonLogger', () => {
       }),
     );
   });
+
+  it('redacter should redact nested object', () => {
+    const redacter = WinstonLogger.redacter();
+    const log = {
+      level: 'error',
+      message: {
+        nested: 'hello (world) from nested object',
+      },
+    };
+
+    redacter.add(['hello']);
+    expect(redacter.format.transform(msg(log))).toEqual(
+      msg({
+        ...log,
+        message: {
+          nested: '[REDACTED] (world) from nested',
+        },
+      }),
+    );
+  });
 });

From 0cda20fa31a4a92ad69a3a3e87d93d4ee64bb0df Mon Sep 17 00:00:00 2001
From: Bethany Griggs <bethanyngriggs@gmail.com>
Date: Fri, 3 May 2024 18:08:37 +0100
Subject: [PATCH 2/2] fixup! typo

Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
---
 packages/backend-app-api/src/logging/WinstonLogger.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/backend-app-api/src/logging/WinstonLogger.test.ts b/packages/backend-app-api/src/logging/WinstonLogger.test.ts
index bec6a9fc0f..d025719d9a 100644
--- a/packages/backend-app-api/src/logging/WinstonLogger.test.ts
+++ b/packages/backend-app-api/src/logging/WinstonLogger.test.ts
@@ -73,7 +73,7 @@ describe('WinstonLogger', () => {
       msg({
         ...log,
         message: {
-          nested: '[REDACTED] (world) from nested',
+          nested: '[REDACTED] (world) from nested object',
         },
       }),
     );