From 536693b2383d1cee002eb47fea1f711891299e80 Mon Sep 17 00:00:00 2001 From: blam Date: Fri, 20 Jan 2023 16:51:30 +0100 Subject: [PATCH] chore: code review comments Signed-off-by: blam --- docs/backend-system/core-services/01-index.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/backend-system/core-services/01-index.md b/docs/backend-system/core-services/01-index.md index fbf228a937..4ef9d75bde 100644 --- a/docs/backend-system/core-services/01-index.md +++ b/docs/backend-system/core-services/01-index.md @@ -239,6 +239,7 @@ The following example is how you can override the root logger service to add add ```ts import { coreServices } from '@backstage/backend-plugin-api'; +import { WinstonLogger } from '@backstage/backend-app-api'; const backend = createBackend({ services: [ @@ -488,7 +489,7 @@ createBackendPlugin({ ## Root Lifecycle -This service is the same as the lifecycle service, but should only be used by the root services. This is also where the implementation for the actual lifecycle hooks torn, so if you want to override the implementation of how the lifecycle hooks are executed, you should override this service. +This service is the same as the lifecycle service, but should only be used by the root services. This is also where the implementation for the actual lifecycle hooks are collected and executed, so if you want to override the implementation of how those are processed, you should override this service. ### Configure the service @@ -656,7 +657,7 @@ createBackendPlugin({ urlReader: coreServices.urlReader, }, async init({ urlReader }) { - const reader = await urlReader + const buffer = await urlReader .read('https://github.com/backstage/backstage/blob/master/README.md') .then(r => r.buffer());