Integration - Removed long deprecated code
Signed-off-by: Andre Wanlin <awanlin@spotify.com> Fixed lock file Signed-off-by: Andre Wanlin <awanlin@spotify.com> Improve changesets Signed-off-by: Andre Wanlin <awanlin@spotify.com> Removed link Signed-off-by: Andre Wanlin <awanlin@spotify.com> Update .changeset/sharp-ravens-shop.md Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com> Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Update .changeset/six-trees-carry.md Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com> Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Update .changeset/tiny-zoos-smash.md Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com> Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Corrected gerrit changes based on feedback Signed-off-by: Andre Wanlin <awanlin@spotify.com> Updated API report Signed-off-by: Andre Wanlin <awanlin@spotify.com> Fixed some tests Signed-off-by: Andre Wanlin <awanlin@spotify.com> Fixed test Signed-off-by: Andre Wanlin <awanlin@spotify.com> Fixed another test Signed-off-by: Andre Wanlin <awanlin@spotify.com> Removed parseGerritGitilesUrl Signed-off-by: Andre Wanlin <awanlin@spotify.com> Table clean up Signed-off-by: Andre Wanlin <awanlin@spotify.com> Remove from changeset Signed-off-by: Andre Wanlin <awanlin@spotify.com> Changes based on feedback Signed-off-by: Andre Wanlin <awanlin@spotify.com>
This commit is contained in:
@@ -28,10 +28,12 @@ describe('RepoPicker Validation', () => {
|
||||
|
||||
const config = new ConfigReader({
|
||||
integrations: {
|
||||
bitbucket: [
|
||||
bitbucketCloud: [
|
||||
{
|
||||
host: 'bitbucket.org',
|
||||
},
|
||||
],
|
||||
bitbucketServer: [
|
||||
{
|
||||
host: 'server.bitbucket.com',
|
||||
},
|
||||
|
||||
@@ -39,9 +39,16 @@ export const repoPickerValidation = (
|
||||
'Incomplete repository location provided, host not provided',
|
||||
);
|
||||
} else {
|
||||
if (integrationApi?.byHost(host)?.type === 'bitbucket') {
|
||||
const integrationType = integrationApi?.byHost(host)?.type;
|
||||
if (
|
||||
integrationType === 'bitbucketCloud' ||
|
||||
integrationType === 'bitbucketServer'
|
||||
) {
|
||||
// workspace is only applicable for bitbucket cloud
|
||||
if (host === 'bitbucket.org' && !searchParams.get('workspace')) {
|
||||
if (
|
||||
integrationType === 'bitbucketCloud' &&
|
||||
!searchParams.get('workspace')
|
||||
) {
|
||||
validation.addError(
|
||||
'Incomplete repository location provided, workspace not provided',
|
||||
);
|
||||
@@ -52,7 +59,7 @@ export const repoPickerValidation = (
|
||||
'Incomplete repository location provided, project not provided',
|
||||
);
|
||||
}
|
||||
} else if (integrationApi?.byHost(host)?.type === 'azure') {
|
||||
} else if (integrationType === 'azure') {
|
||||
if (!searchParams.get('project')) {
|
||||
validation.addError(
|
||||
'Incomplete repository location provided, project not provided',
|
||||
|
||||
Reference in New Issue
Block a user